Open
Conversation
- French - Malaysian - Russian
elegaanz
reviewed
Jan 9, 2026
Member
elegaanz
left a comment
There was a problem hiding this comment.
Just a small remark to make sure your README is properly rendered on Typst Universe, otherwise looks good to me.
May I ask why you forked name-it? Is it no longer maintained?
|
|
||
| ## Example | ||
| ### In English! | ||
|  |
Member
There was a problem hiding this comment.
You should either:
- copy the example images to this repository (but
excludethem in your manifest) - or link to your own GitHub repo here instead of using a relative URL (i.e use
https://raw.githubusercontent.com/IrregularPersona/polyglot-numbers/d4ddc9a244b74ce3ad5f3b86d2e108129ca1f8a7/examples/example-en.png). If you go for that option, please make sure to specify a commit hash or git tag name in the URL (and not a branch name), so that the image doesn't change if you decide to update the example in a future version.
Member
There was a problem hiding this comment.
The same applies to other example images.
Author
|
It seems like the original repo isn't being continued (realistically, one implementation of this is complete), and the creator seemed to be focused on other things right now. I just built my part, around what they did. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am submitting
Description: A fork of the
name-itpackage, but meant to be modularized for localization with more than just the English language.I have read and followed the submission guidelines and, in particular, I
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfile or linked one in myREADME.mdexcluded PDFs or README images, if any, but not the LICENSE