fix: overwrite validation decorators from parent class when defined i…

[rdubigny]

Description

This is an updated rebase of #748 .

Fixes a bug that caused decorated properties which are also decorated in inherited classes, to skip their inherited validation.

Checklist

• the pull request title describes what this PR does (not a vague title like Update index.md)
• the pull request targets the default branch of the repository (develop)
• the code follows the established code style of the repository
  • npm run prettier:check passes
  • npm run lint:check passes
• tests are added for the changes I made (if any source code was modified)
• documentation added or updated
• I have run the project locally and verified that there are no errors

Fixes

fixes #633 , fixes #622

[Setitch]

Great idea @rdubigny, have you maybe thought of a way to exclude parent validator from being used?
Example:

class Parent {
  @IsString()
  roomNumber: string;
}
class Child {
  @IsNumber()
  @Off(@IsString())
  roomNumber: number;
}

Or anything like that maybe?

[rdubigny]

Great idea @rdubigny, have you maybe thought of a way to exclude parent validator from being used? Example:

class Parent {
  @IsString()
  roomNumber: string;
}
class Child {
  @IsNumber()
  @Off(@IsString())
  roomNumber: number;
}

Or anything like that maybe?

Hello @Setitch,

In this PR, I focused solely on updating #748 without trying to introduce any new changes.

That said, I’m not convinced this is a good idea. In TypeScript, inheritance follows the Liskov Substitution Principle, which states:

Wherever a MyClass is expected, a MySubClass must be usable as well.

If a parent class defines roomNumber as a string, TypeScript expects roomNumber to remain a string in all subclasses that inherit from it.