Initial naive implementation for method arguments decorator validation#2432
Open
PavelLoparev wants to merge 3 commits intotypestack:developfrom
Open
Initial naive implementation for method arguments decorator validation#2432PavelLoparev wants to merge 3 commits intotypestack:developfrom
PavelLoparev wants to merge 3 commits intotypestack:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces method's arguments validation.
Checklist
Update index.md)develop)npm run prettier:checkpassesnpm run lint:checkpassesFixes
#115
This is a naive implementation that can be extended if needed.
How it works:
IsNotEmptyArgumentargument decorator "registers" validation in the target object (just an array of strings like<methodName>:<parameterIndex>:<validatorName>)ValidateArgumentsmethod decorator reads all registered validations and executes them.This scheme with 2 decorators instead of just one argument decorator is only needed because argument level decorator can't access actual argument value (it's weird)
Usage example: