Merged
Conversation
Replace the vulnerable `ecdsa` library (CVE-2024-23342) with the production-grade `cryptography` library for all ECDSA operations. Closes tr4nt0r#69
The cryptography library produces different RFC 6979 nonces than ecdsa did, so the hardcoded expected signatures needed updating. Also re-wrapped the test PEM file to 64-char lines (what cryptography exports) so the round-trip import/export test passes again.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
==========================================
- Coverage 88.34% 88.31% -0.03%
==========================================
Files 54 54
Lines 2857 2868 +11
==========================================
+ Hits 2524 2533 +9
- Misses 333 335 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tr4nt0r
requested changes
Feb 26, 2026
Owner
tr4nt0r
left a comment
There was a problem hiding this comment.
Thanks for your contribution. I'm not familiar with this cryptography thing, so your help is very welcome. Just a small change, otherwise it looks good 👍🏼
tr4nt0r
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the vulnerable
ecdsalibrary with the production-gradecryptographylibrary for all ECDSA operations.The
ecdsapackage is vulnerable to CVE-2024-23342 and the upstream author explicitly states it should not be used in production:Closes #69