Conversation
✱ Stainless preview buildsThis PR will update the ✅ togetherai-python studio · code
|
openapi.yaml
Outdated
| message: | ||
| type: string | ||
| description: Message indicating the result of the deletion | ||
| HyperParameterLimits: |
There was a problem hiding this comment.
Not sure what you guys think of the name HyperParameterLimits, thats the name in the codebase but these arent all strictly hyperparams, I guess we could do FineTuneModelLimits instead, wdyt
There was a problem hiding this comment.
I'm ok with just doing FineTuneModelLimits to avoid confusion
| x-codeSamples: | ||
| - lang: Shell | ||
| label: cURL | ||
| source: | |
There was a problem hiding this comment.
I asked max about this, we dont cdn cache in case the limits update on our end. Note: this is the SSOT for sequence lengths, etc
openapi.yaml
Outdated
| schema: | ||
| type: string | ||
| required: true | ||
| description: The model name to get limits for. |
There was a problem hiding this comment.
same for putting description in schema here
openapi.yaml
Outdated
| description: Message indicating the result of the deletion | ||
| HyperParameterLimits: | ||
| type: object | ||
| description: Hyperparameter limits for a fine-tuning model. |
There was a problem hiding this comment.
note, all of these fields are going to be marked as optional in the produced code. You have to add a required: [] field and list all properties that are not optional.
blainekasten
left a comment
There was a problem hiding this comment.
This is looking great! I need to request that you add required markers to the types before we merge.
Also sharing this that I'm requesting citadel to add a field for product support that would change the way we query for model support in by product potentially meaning we could deprecate this API endpoing
37bae39 to
3c758ce
Compare
Thanks for the heads up, this is fine as long as that endpoint surfaces the information contained in shaping's models.yaml, which we can sync about later. |
| description: Hyperparameter limits for a fine-tuning model. | ||
| description: Model limits for fine-tuning. | ||
| required: | ||
| - model_name |
There was a problem hiding this comment.
Based on what isnt omitempty in the go struct
This PR adds two already existing endpoints to openapi, both relating to supported models in the FT API.