Update DecodedRequest and Uri classes for improved route parameter handling.#49
Update DecodedRequest and Uri classes for improved route parameter handling.#49gustavofreze merged 2 commits intomainfrom
Conversation
…rameter handling.
There was a problem hiding this comment.
Pull request overview
Updates request decoding to use accessor methods and adds framework-agnostic route parameter resolution with multi-step fallbacks.
Changes:
- Replace
DecodedRequestpublic properties withuri()/body()accessors and update usages in tests/docs. - Add
RouteParameterResolverto extract route params from arrays/objects/common attribute keys/direct attributes. - Expand test coverage for multiple framework-style route parameter formats and document the resolution order.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/RequestTest.php | Updates decoding API usage and adds integration-style tests for various route param sources. |
| tests/Internal/Request/RouteParameterResolverTest.php | Adds unit tests for the new route parameter resolver behavior. |
| src/Internal/Request/Uri.php | Adds fallback-based route parameter lookup backed by RouteParameterResolver. |
| src/Internal/Request/RouteParameterResolver.php | Introduces framework-agnostic extraction of route parameters from request attributes. |
| src/Internal/Request/DecodedRequest.php | Switches from public properties to accessor methods. |
| README.md | Updates examples and documents the new route parameter resolution strategy. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 38d625c08a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…rameter handling.
No description provided.