Skip to content

Update DecodedRequest and Uri classes for improved route parameter handling.#49

Merged
gustavofreze merged 2 commits intomainfrom
feature/develop
Feb 13, 2026
Merged

Update DecodedRequest and Uri classes for improved route parameter handling.#49
gustavofreze merged 2 commits intomainfrom
feature/develop

Conversation

@gustavofreze
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings February 13, 2026 02:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates request decoding to use accessor methods and adds framework-agnostic route parameter resolution with multi-step fallbacks.

Changes:

  • Replace DecodedRequest public properties with uri() / body() accessors and update usages in tests/docs.
  • Add RouteParameterResolver to extract route params from arrays/objects/common attribute keys/direct attributes.
  • Expand test coverage for multiple framework-style route parameter formats and document the resolution order.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
tests/RequestTest.php Updates decoding API usage and adds integration-style tests for various route param sources.
tests/Internal/Request/RouteParameterResolverTest.php Adds unit tests for the new route parameter resolver behavior.
src/Internal/Request/Uri.php Adds fallback-based route parameter lookup backed by RouteParameterResolver.
src/Internal/Request/RouteParameterResolver.php Introduces framework-agnostic extraction of route parameters from request attributes.
src/Internal/Request/DecodedRequest.php Switches from public properties to accessor methods.
README.md Updates examples and documents the new route parameter resolution strategy.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 38d625c08a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@gustavofreze gustavofreze merged commit 3b1387b into main Feb 13, 2026
5 checks passed
@gustavofreze gustavofreze deleted the feature/develop branch February 13, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant