Add deployments and get/watch to migration RBAC#4630
Open
caseydavenport wants to merge 1 commit intotigera:masterfrom
Open
Add deployments and get/watch to migration RBAC#4630caseydavenport wants to merge 1 commit intotigera:masterfrom
caseydavenport wants to merge 1 commit intotigera:masterfrom
Conversation
The migration controller now checks both calico-node and calico-typha (as DaemonSet or Deployment) for the v3 API group env var during the Converged phase. Add get permission and include deployments in the migration ClusterRole. Also add watch for CRDs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The migration controller now checks both calico-node and calico-typha (as DaemonSet or Deployment) for the v3 API group env var during the Converged phase. The migration ClusterRole needs
getpermission on daemonsets (previously only hadlist/watch), and also needs access to deployments for calico-typha Deployment installs. Also addswatchfor CRDs.Related: projectcalico/calico#12062