Add CalicoEnterprise variant and deprecate TigeraSecureEnterprise#4607
Open
caseydavenport wants to merge 5 commits intotigera:masterfrom
Open
Add CalicoEnterprise variant and deprecate TigeraSecureEnterprise#4607caseydavenport wants to merge 5 commits intotigera:masterfrom
caseydavenport wants to merge 5 commits intotigera:masterfrom
Conversation
Introduce CalicoEnterprise as the preferred ProductVariant value for enterprise installations, replacing the legacy TigeraSecureEnterprise name. Both values remain accepted for backwards compatibility. - Add IsEnterprise() method on ProductVariant so callers don't need to check for both values individually - Replace all direct == TigeraSecureEnterprise comparisons with IsEnterprise() across controllers and render packages - Rename DefaultTSEEInstanceKey to DefaultEnterpriseInstanceKey - Update TSEE references in comments and docs to say "enterprise" - Add deprecation warning on tigerastatus when TigeraSecureEnterprise is used - Regenerate CRDs to include CalicoEnterprise in the enum
caseydavenport
commented
Mar 27, 2026
| } | ||
| if variant != operatorv1.TigeraSecureEnterprise { | ||
| r.status.SetDegraded(operatorv1.ResourceNotReady, fmt.Sprintf("Waiting for network to be %s", operatorv1.TigeraSecureEnterprise), nil, reqLogger) | ||
| if !variant.IsEnterprise() { |
Member
Author
There was a problem hiding this comment.
Eeek, next PR is going to be to replace "network" with "Installation"
Update all test files and docs to use CalicoEnterprise instead of the deprecated TigeraSecureEnterprise constant. This fixes staticcheck SA1019 warnings from the linter.
Not ready to surface this warning to users yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
CalicoEnterpriseas a newProductVariantvalue that's logically equivalent to the existingTigeraSecureEnterprise. The old value still works, but is now marked as deprecated — users settingvariant: TigeraSecureEnterprisewill see a deprecation warning ontigerastatuspointing them to useCalicoEnterpriseinstead.To support both values without duplicating checks everywhere, this adds an
IsEnterprise()method onProductVariantand replaces all the direct== TigeraSecureEnterprise/!= TigeraSecureEnterprisecomparisons with it. Also takes the opportunity to clean up some legacy naming —DefaultTSEEInstanceKey→DefaultEnterpriseInstanceKey, and various "TSEE" references in comments and docs → "enterprise".No user-facing behavior changes —
TigeraSecureEnterprisecontinues to work as before.