Conversation
Its value is inaccurate in JSON[^1], which doesn't store a timezone
with timestamps, but rather always uses UTC and converts via the
browser's timezone.
For this reason the values are left in for other formats, which
combined with the local offset field, can properly determine the
value.
[^1]: unless the user's timezone matches that of the server providing
the data (that's typically UTC)
BACK-4205
ewollesen
force-pushed
the
eric-localtime
branch
from
11eb905 to
500bcf6
Compare
|
The build failure is because the matching version of node-data-tools hasn't been merged yet. tidepool-org/node-data-tools#26 |
There was a problem hiding this comment.
Pull request overview
This PR updates the @tidepool/data-tools library from version 2.4.2 to 3.0.0, which is a major version upgrade that includes a fix for localTime formatting. The code changes configure the data processor to exclude localTime fields from JSON exports while retaining them in Excel exports.
Changes:
- Updated
@tidepool/data-toolsdependency from 2.4.2 to 3.0.0 - Added
excludeLocalTimeconfiguration option to processorConfig that is set totruefor JSON exports andfalsefor Excel exports
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated @tidepool/data-tools dependency to version 3.0.0 |
| lib/handlers/userDataHandler.mjs | Added excludeLocalTime configuration to exclude localTime from JSON exports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@babel/preset-env": "7.25.4", | ||
| "@godaddy/terminus": "4.12.1", | ||
| "@tidepool/data-tools": "2.4.2", | ||
| "@tidepool/data-tools": "3.0.0", |
There was a problem hiding this comment.
will need to bump this when the actual version is pushed to npm
darinkrauss
left a comment
darinkrauss
left a comment
There was a problem hiding this comment.
Need to update package.json to update version of @tidepool/data-tools to "2.5.0".
Includes a fix for localTime formatting.
BACK-4205