Conversation
fd164bb to
675e891
Compare
There was a problem hiding this comment.
Code Review: [Automated] Update flux CLI Options
This is an automated PR updating the Flux CLI options classes based on the latest CLI help output. All changed files have the suffix — they should not be modified by hand, and the generator is the authoritative source.
Summary of Changes
- AssemblyInfo.Generated.cs: Timestamp bumped from to (expected for a regeneration).
- ~153 existing options files: New option added to every options class. This maps to the Kubernetes impersonation feature for passing extra user info alongside and .
- FluxCreateSecretGithubappOptions.Generated.cs: New option added for specifying the GitHub App installation owner.
- 2 new files:
FluxExportSourceExternalOptionsandFluxGetSourcesExternalOptionsfor the newexternalsource type in Flux. - 2 updated service files:
FluxExportSourceandFluxGetSourcesnow exposeExternal()methods.
Assessment
The generation looks correct and consistent:
-
**** is correctly modelled as with and . This matches how kubectl handles repeated flags (e.g. ), so the serialisation behaviour will be correct.
-
**** is a single-value string option, which is appropriate.
-
The two new source types follow the same structural pattern as the existing , , , , and sources — method signatures are consistent, default-parameter null coalescing is used correctly, and XML docs are present.
-
All generated files carry as per the project convention, so these additions won't negatively affect coverage metrics.
No issues found
The output of the generator is clean and consistent. This PR looks good to merge.
There was a problem hiding this comment.
Code Review: [Automated] Update flux CLI Options
This is an automated PR updating the Flux CLI options classes based on the latest CLI help output. All changed files carry the .Generated.cs suffix and are managed by the OptionsGenerator — they should not be modified by hand.
Summary of Changes
- AssemblyInfo.Generated.cs: Timestamp bumped from 2026-02-15 to 2026-03-01, as expected for a regeneration.
- ~153 existing options files: New
--as-user-extraoption added to every options class. This corresponds to the Kubernetes impersonation feature for passing extra user info alongside--asand--as-uid. - FluxCreateSecretGithubappOptions.Generated.cs: New
--app-installation-owneroption added for specifying the GitHub App installation owner. - 2 new files:
FluxExportSourceExternalOptionsandFluxGetSourcesExternalOptionsfor the newexternalsource type in Flux. - 2 updated service files:
FluxExportSourceandFluxGetSourcesnow exposeExternal()methods.
Assessment
The generation looks correct and consistent:
-
--as-user-extrais correctly modelled asIEnumerable<string>?withAllowMultiple = trueandOptionFormat.EqualsSeparated. This matches how kubectl handles repeated flags (e.g.--as-user-extra=key=val --as-user-extra=key2=val2), so the serialisation behaviour will be correct. -
--app-installation-owneris a straightforward single-value string option, which is appropriate. -
The two new
Externalsource types follow the same structural pattern as the existingChart,Git,Helm,Oci, andBucketsources — method signatures are consistent, null-coalescing of default parameters is used correctly, and XML docs are present. -
All generated files carry
[ExcludeFromCodeCoverage]as per the project convention, so these additions will not negatively affect coverage metrics.
No issues found
The generator output is clean and consistent. This PR looks good to merge.
Summary
This PR contains automatically generated updates to flux CLI options classes.
The generator scraped the latest CLI help output from the installed tool.
Changes
Verification
🤖 Generated with ModularPipelines.OptionsGenerator