Skip to content

[Automated] Update flux CLI Options#2418

Open
thomhurst wants to merge 1 commit intomainfrom
automated/update-cli-options-flux
Open

[Automated] Update flux CLI Options#2418
thomhurst wants to merge 1 commit intomainfrom
automated/update-cli-options-flux

Conversation

@thomhurst
Copy link
Owner

Summary

This PR contains automatically generated updates to flux CLI options classes.

The generator scraped the latest CLI help output from the installed tool.

Changes

  • Updated options classes to reflect latest CLI documentation
  • Added new commands if any were detected
  • Updated option types and descriptions

Verification

  • Solution builds successfully

🤖 Generated with ModularPipelines.OptionsGenerator

@thomhurst thomhurst added automated dependencies Pull requests that update a dependency file labels Feb 22, 2026
@thomhurst thomhurst enabled auto-merge (squash) February 22, 2026 03:13
@thomhurst thomhurst force-pushed the automated/update-cli-options-flux branch from fd164bb to 675e891 Compare March 1, 2026 03:15
Copy link

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: [Automated] Update flux CLI Options

This is an automated PR updating the Flux CLI options classes based on the latest CLI help output. All changed files have the suffix — they should not be modified by hand, and the generator is the authoritative source.

Summary of Changes

  • AssemblyInfo.Generated.cs: Timestamp bumped from to (expected for a regeneration).
  • ~153 existing options files: New option added to every options class. This maps to the Kubernetes impersonation feature for passing extra user info alongside and .
  • FluxCreateSecretGithubappOptions.Generated.cs: New option added for specifying the GitHub App installation owner.
  • 2 new files: FluxExportSourceExternalOptions and FluxGetSourcesExternalOptions for the new external source type in Flux.
  • 2 updated service files: FluxExportSource and FluxGetSources now expose External() methods.

Assessment

The generation looks correct and consistent:

  1. **** is correctly modelled as with and . This matches how kubectl handles repeated flags (e.g. ), so the serialisation behaviour will be correct.

  2. **** is a single-value string option, which is appropriate.

  3. The two new source types follow the same structural pattern as the existing , , , , and sources — method signatures are consistent, default-parameter null coalescing is used correctly, and XML docs are present.

  4. All generated files carry as per the project convention, so these additions won't negatively affect coverage metrics.

No issues found

The output of the generator is clean and consistent. This PR looks good to merge.

Copy link

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: [Automated] Update flux CLI Options

This is an automated PR updating the Flux CLI options classes based on the latest CLI help output. All changed files carry the .Generated.cs suffix and are managed by the OptionsGenerator — they should not be modified by hand.

Summary of Changes

  • AssemblyInfo.Generated.cs: Timestamp bumped from 2026-02-15 to 2026-03-01, as expected for a regeneration.
  • ~153 existing options files: New --as-user-extra option added to every options class. This corresponds to the Kubernetes impersonation feature for passing extra user info alongside --as and --as-uid.
  • FluxCreateSecretGithubappOptions.Generated.cs: New --app-installation-owner option added for specifying the GitHub App installation owner.
  • 2 new files: FluxExportSourceExternalOptions and FluxGetSourcesExternalOptions for the new external source type in Flux.
  • 2 updated service files: FluxExportSource and FluxGetSources now expose External() methods.

Assessment

The generation looks correct and consistent:

  1. --as-user-extra is correctly modelled as IEnumerable<string>? with AllowMultiple = true and OptionFormat.EqualsSeparated. This matches how kubectl handles repeated flags (e.g. --as-user-extra=key=val --as-user-extra=key2=val2), so the serialisation behaviour will be correct.

  2. --app-installation-owner is a straightforward single-value string option, which is appropriate.

  3. The two new External source types follow the same structural pattern as the existing Chart, Git, Helm, Oci, and Bucket sources — method signatures are consistent, null-coalescing of default parameters is used correctly, and XML docs are present.

  4. All generated files carry [ExcludeFromCodeCoverage] as per the project convention, so these additions will not negatively affect coverage metrics.

No issues found

The generator output is clean and consistent. This PR looks good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant