boards: ace30: Enable CONFIG_UAOL for PTL#10616
Open
majunkier wants to merge 1 commit intothesofproject:mainfrom
Open
boards: ace30: Enable CONFIG_UAOL for PTL#10616majunkier wants to merge 1 commit intothesofproject:mainfrom
majunkier wants to merge 1 commit intothesofproject:mainfrom
Conversation
majunkier
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Enables the Zephyr UAOL (USB Audio Offload Link) driver on the intel_adsp_ace30_ptl board configuration to restore builds after UAOL stopped being enabled by default upstream.
Changes:
- Turn on
CONFIG_UAOL=yfor the PTL board config to avoid UAOL-related link failures.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -56,6 +56,7 @@ CONFIG_MM_DRV_INTEL_ADSP_TLB_REMAP_UNUSED_RAM=y | |||
| CONFIG_MM_DRV_INTEL_VIRTUAL_REGION_COUNT=2 | |||
| CONFIG_XTENSA_MMU_NUM_L2_TABLES=128 | |||
| CONFIG_SYS_CLOCK_TICKS_PER_SEC=12000 | |||
There was a problem hiding this comment.
Consider adding a short comment explaining why CONFIG_UAOL must be enabled for PTL (e.g., UAOL no longer default-enabled since Zephyr commit fc2b1b2f3e2 and disabling causes linker errors / missing UAOL device). This will help future maintainers understand why the symbol is forced on in this board config.
Suggested change
| CONFIG_SYS_CLOCK_TICKS_PER_SEC=12000 | |
| CONFIG_SYS_CLOCK_TICKS_PER_SEC=12000 | |
| # UAOL is no longer default-enabled since Zephyr commit fc2b1b2f3e2; | |
| # it must be forced on for PTL or the build fails with linker errors | |
| # due to the missing UAOL device. |
Starting from Zephyr commit fc2b1b2f3e2 ("drivers: uaol: Do not enable
by default UAOL"), the UAOL (USB Audio Offload Link) driver is no
longer enabled by default. This change cause build failures
with linker errors:
undefined reference to `__device_dts_ord_110'
This commit enables CONFIG_UAOL=y for PTL
Signed-off-by: Mateusz Junkier <mateusz.junkier@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from Zephyr commit fc2b1b2f3e2 ("drivers: uaol: Do not enable by default UAOL"), the UAOL (USB Audio Offload Link) driver is no longer enabled by default. This change cause build failures with linker errors:
undefined reference to `__device_dts_ord_110'
This commit enables CONFIG_UAOL=y for PTL