Skip to content

dp: nocodec: switch playback SRC to DP by default#10469

Merged
lgirdwood merged 10 commits intothesofproject:mainfrom
lyakh:tplg
Feb 10, 2026
Merged

dp: nocodec: switch playback SRC to DP by default#10469
lgirdwood merged 10 commits intothesofproject:mainfrom
lyakh:tplg

Conversation

@lyakh
Copy link
Collaborator

@lyakh lyakh commented Jan 6, 2026

Switch one of the two SRC instances in the nocodec topology to DP mode by default.

@softwarecki softwarecki self-requested a review January 7, 2026 14:31
@lgirdwood
Copy link
Member

lgirdwood commented Jan 7, 2026

@lyakh Some nocodec failings.

@lyakh
Copy link
Collaborator Author

lyakh commented Jan 8, 2026

@lyakh Some nocodec failings.

@lgirdwood yes, I've traced it back to an update in Zephyr, which had disabled double mapping. I'm working to fix it.

@lyakh lyakh marked this pull request as ready for review January 9, 2026 13:39
Copilot AI review requested due to automatic review settings January 9, 2026 13:39
Copilot AI reviewed Jan 9, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR switches the playback SRC (Sample Rate Converter) to use the DP (Data Processing) domain by default in the nocodec topology, while keeping the capture SRC in the default domain. Additionally, it adds cached memory partition support for DP scheduler tasks.

Key changes:

  • Splits the SRC domain configuration into separate playback and capture domains
  • Adds cached memory partition support (HEAP_CACHE and CFG_CACHE) for improved memory access patterns
  • Updates test topology parameters to maintain capture path DP testing

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
tools/topology/topology2/cavs-nocodec.conf Splits SRC_DOMAIN into SRC_DOMAIN_PLAYBACK (DP) and SRC_DOMAIN_CAPTURE (default) and updates widget configurations
tools/topology/topology2/development/tplg-targets.cmake Updates test topology parameters from SRC_DOMAIN to SRC_DOMAIN_CAPTURE for MTL, LNL, and PTL platforms
src/schedule/zephyr_dp_schedule_application.c Adds cached memory partition initialization and cleanup for both heap and mailbox partitions
src/schedule/zephyr_dp_schedule.h Extends the sof_dp_part_type enum with HEAP_CACHE and CFG_CACHE partition types

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lyakh lyakh added the DNM Do Not Merge tag label Jan 9, 2026
@lyakh
Copy link
Collaborator Author

lyakh commented Jan 12, 2026

SOFCI TEST

@lyakh
Copy link
Collaborator Author

lyakh commented Jan 12, 2026

retest with #10474 merged

@lyakh
Copy link
Collaborator Author

lyakh commented Jan 12, 2026

SOFCI TEST

@lyakh
Copy link
Collaborator Author

lyakh commented Jan 14, 2026

SOFCI TEST

@lyakh lyakh force-pushed the tplg branch 3 times, most recently from b653aa5 to 1f3c6ed Compare January 22, 2026 09:40
@lyakh
Copy link
Collaborator Author

lyakh commented Jan 22, 2026

SOFCI TEST

@lyakh
Copy link
Collaborator Author

lyakh commented Feb 6, 2026

https://github.com/thesofproject/sof/actions/runs/21742080825/job/62719480359?pr=10469 is a regression introduced by #10523 #10523 (comment)

lyakh added 4 commits February 6, 2026 10:52
@lyakh
dp: application: restore double mapping for userspace
92a2be0 
Since Zephyr has removed double mapping per Kconfig switch we need to
restore it in SOF. Next we should try to optimize mappings to only
use the ones we really need.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@lyakh
dp: don't schedule paused tasks
d52aeb1 
DP tasks don't need to be rescheduled when pause is released. Default
handling works correctly in that case too.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@lyakh
objpool: fix flag initialisation
23b0a00 
We compare flags on repeated allocations from an existing pool, but
initialisation got forgotten in the process. Restore it.

Fixes: d6e6ac5 ("Add a object pool allocator")
Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@lyakh
dp: user: fix objpool allocation error handling
85323f9 
When an objpool allocation fails an error should be returned. Fix the
missing error code assignment.

Fixes: fc73f9d ("sp: application: switch memory domains to object pools")
Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@lyakh lyakh requested a review from RanderWang as a code owner February 6, 2026 09:53
@lyakh
Copy link
Collaborator Author

lyakh commented Feb 6, 2026

d263649 reverted because of a regression in SRC DP:

[  280.863861] <wrn> module_adapter: module_ext_init_decode: dp_data object too small 12 < 20
[  280.864021] <wrn> module_adapter: z_impl_mod_alloc_ext: mngr (nil) != cur 0x401907d0
[  280.865958] <inf> dp_schedule: dp_thread_fn: comp:0 0x100f userspace thread started
[  280.866228] <err> src_init: comp:0 0x100f Missing or bad size (44) init data
[  280.866368] <err> module_adapter: module_init: comp:0 0x100f error -22: module specific init failed
[  280.866446] <err> module_adapter: module_adapter_new_ext: comp:0 0x100f -22: module initialization failed
[  280.866905] <err> module_adapter: z_impl_mod_free: comp:0 0x100f error: could not find memory pointed by 0x40204380
[  280.867976] <err> ipc: ipc4_init_module_instance: error: failed to init module 100f : 0
[  280.868035] <err> ipc: ipc_cmd: ipc4: MODULE_MSG failed with err 104

https://sof-ci.01.org/sofpr/PR10469/build19047/devicetest/index.html?model=PTLH_RVP_NOCODEC&testcase=check-playback-10sec

@lyakh
audio: module-adapter: fix SRC DP regression
c857654 
A recent module-adapter feature addition broke SRC DP support. Fix it
by adding a test for incomplete initialization data.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@lyakh
Copy link
Collaborator Author

lyakh commented Feb 6, 2026

SOFCI TEST

@lyakh
Copy link
Collaborator Author

lyakh commented Feb 6, 2026

nocodec PTL missing. rerun

@lgirdwood
Copy link
Member

lgirdwood commented Feb 6, 2026

nocodec PTL missing. rerun

Results in with some data about the failure. https://sof-ci.01.org/sofpr/PR10469/build19078/devicetest/index.html?model=PTLH_RVP_NOCODEC&testcase=check-capture-3times

@lyakh lyakh requested a review from dabekjakub as a code owner February 6, 2026 16:18
@lyakh lyakh force-pushed the tplg branch 2 times, most recently from 2f076d8 to b0263bd Compare February 10, 2026 11:28
lyakh added 5 commits February 10, 2026 14:48
@lyakh
Revert "audio: module-adapter: use objpool for allocation containers"
99fc1c2 
This reverts commit 8acc9ca. It
seems to break certain capture flows, revert it until fixed.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@lyakh
audio: fast-get: fast_get() and fast_put() should not be syscalls
1b01c02 
Userspace modules should only call mod_fast_get() and mod_fast_put(),
which already can cross into the kernel space on their own, so
fast_get() and fast_put() themselves don't need to be syscalls.
Remove their syscall implementations.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@lyakh
fast_get: replace tr_dbg() and tr_err() with LOG_*()
46ac045 
fast_get.c doesn't have a "trace context" - it doesn't have a
DECLARE_TR_CTX() call. Hencs all calls to tr_err() and friends are
wrong. Replace them with respective LOG_*() analogs.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@lyakh
fast-get: enable sharing between userspace threads
fe86c2b 
If a module fast-gets memory for a specific its instance, running in
userspace and then another usuerspace instance wants to share it,
access has to be granted to that object by that thread too. This
patch does that while also restricting object sharing to "large"
objects (currently larger than half a page), and smaller objects are
just copied.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@lyakh
dp: nocodec: switch SRC to DP by default
d946517 
Switch both SRC instances in the nocodec topology on PTL to DP mode
by default.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@lgirdwood lgirdwood dismissed softwarecki’s stale review February 10, 2026 15:52

Old review from earlier version of PR. PR changed, updates for FLIX and alignment was reached to maintain the review history over splitting PR to re-review.

@lgirdwood lgirdwood merged commit 73c9684 into thesofproject:main Feb 10, 2026
49 of 52 checks passed
@lyakh lyakh deleted the tplg branch February 10, 2026 15:53
@tmleman
Copy link
Contributor

tmleman commented Feb 27, 2026

Commit fe86c2b introduced regression in SRC on PTL platform:

[   23.843020] <inf> dma: z_impl_sof_dma_put: dma_put(), dma = 0x400c0348, sref = 0
[   23.843040] <err> os: print_fatal_exception:  ** FATAL EXCEPTION
[   23.843040] <err> os: print_fatal_exception:  ** CPU 0 EXCCAUSE 28 (load prohibited)
[   23.843040] <err> os: print_fatal_exception:  **  PC 0xa0042e82 VADDR 0xa01c3000
[   23.843040] <err> os: print_fatal_exception:  **  PS 0x60523
[   23.843040] <err> os: print_fatal_exception:  **    (INTLEVEL:3 EXCM: 0 UM:1 RING:0 WOE:1 OWB:5 CALLINC:2)
[   23.843040] <err> os: xtensa_dump_stack:      **  A0 0xa006c9af  SP 0xa00e5b70  A2 0xa01c3000  A3 0x40
[   23.843040] <err> os: xtensa_dump_stack:      **  A4 0x17e346  A5 0x91b9  A6 0xa01c3000  A7 0x40171324
[   23.843040] <err> os: xtensa_dump_stack:      **  A8 0xa01c403f  A9 0xa01b2000 A10 (nil) A11 0xa01c3000
[   23.843040] <err> os: xtensa_dump_stack:      ** A12 0x1 A13 0x60123 A14 0x4017176c A15 0x103f
[   23.843050] <err> os: xtensa_dump_stack:      ** LBEG 0xa0042e82 LEND 0xa0042e88 LCOUNT 0x3f
[   23.843050] <err> os: xtensa_dump_stack:      ** SAR 0x20
[   23.843050] <err> os: xtensa_dump_stack:      **  THREADPTR (nil)

fyi @lyakh @lgirdwood

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abonislawski abonislawski abonislawski approved these changes

Copilot code review Copilot Copilot left review comments

@lgirdwood lgirdwood lgirdwood approved these changes

@kv2019i kv2019i kv2019i approved these changes

@softwarecki softwarecki softwarecki left review comments

@ranj063 ranj063 Awaiting requested review from ranj063 ranj063 is a code owner

@jsarha jsarha Awaiting requested review from jsarha jsarha is a code owner

@pblaszko pblaszko Awaiting requested review from pblaszko pblaszko is a code owner

@marcinszkudlinski marcinszkudlinski Awaiting requested review from marcinszkudlinski marcinszkudlinski is a code owner

@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta is a code owner

@LaurentiuM1234 LaurentiuM1234 Awaiting requested review from LaurentiuM1234 LaurentiuM1234 is a code owner

@plbossart plbossart Awaiting requested review from plbossart plbossart is a code owner

@mmaka1 mmaka1 Awaiting requested review from mmaka1 mmaka1 is a code owner

@lbetlej lbetlej Awaiting requested review from lbetlej lbetlej is a code owner

@iuliana-prodan iuliana-prodan Awaiting requested review from iuliana-prodan iuliana-prodan is a code owner

@jxstelter jxstelter Awaiting requested review from jxstelter jxstelter is a code owner

@RanderWang RanderWang Awaiting requested review from RanderWang

@dabekjakub dabekjakub Awaiting requested review from dabekjakub dabekjakub is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@lyakh @lgirdwood @softwarecki @abonislawski @tmleman @kv2019i