Closed
Conversation
pageantry
changed the title
whiskey-coder
approved these changes
Jun 3, 2025
kafkiansky
reviewed
Feb 28, 2026
README.md
Outdated
| You can create a `TimeSpan` instance using various static factory methods depending on your source unit. | ||
|
|
||
| ```php | ||
| use YourVendor\TimeSpan; |
Contributor
There was a problem hiding this comment.
Suggested change
| use YourVendor\TimeSpan; | |
| use Thesis\TimeSpan; |
|
|
||
| ### ⚠️ Important: Nanoseconds and IEEE 754 | ||
|
|
||
| The core method `TimeSpan::fromNanoseconds(int|float $nanoseconds)` accepts both integers and floating-point numbers. However, users must be aware of **IEEE 754 floating-point limitations**. |
Contributor
There was a problem hiding this comment.
Can we use bcmath to resolve this issue?
Contributor
There was a problem hiding this comment.
Well, the question is whether we need that really here...
Contributor
|
Thank you, guys! Based on this + a lot of other changes I've created an alternative commit: 9128ef8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #3