Skip to content

fix(sdk): Add status_code to ApiError #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rendez wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(sdk): Add status_code to ApiError #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/thecompaniesapi/sdk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def _make_request(
# If response is not JSON, return text content
return {'data': response.text, 'status': response.status_code}

except requests.exceptions.RequestException as e:
except Exception as e:
raise ApiError.from_request_exception(e, f"Request failed: {str(e)}") from e

def get(
Expand Down Expand Up @@ -193,7 +193,7 @@ def __init__(self, message: str, status_code: int | None = None) -> None:
self.status_code = status_code

@classmethod
def from_request_exception(cls, e: ApiError, message: str) -> "ApiError":
def from_request_exception(cls, e: Exception, message: str) -> "ApiError":
status_code = None
cause = e.__cause__
if isinstance(cause, requests.HTTPError) and cause.response is not None:
Expand Down