fix(qdrant): migrate Qdrant from deprecated decorator.#963
Open
ethanlee928 wants to merge 2 commits intotestcontainers:mainfrom
Open
fix(qdrant): migrate Qdrant from deprecated decorator.#963ethanlee928 wants to merge 2 commits intotestcontainers:mainfrom
ethanlee928 wants to merge 2 commits intotestcontainers:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hello, this PR addresses the deprecation warning coming from
QdrantContainer.The container currently uses the deprecated
@wait_container_is_ready()decorator, which is scheduled for removal.This change migrates to the recommended
LogMessageWaitStrategy.Additionally, the Qdrant Docker image version has been updated to match the Qdrant client version, resolving the following warning:
UserWarning: Qdrant client version 1.16.2 is incompatible with server version 1.13.5.Testing
All qdrant test cases passed:
poetry run pytest modules/qdrant/tests/ -v ============== 4 passed, 3 warnings in 3.07s ==============The remaining warnings are related to
UserWarning: Api key is used with an insecure connection., which is out of scope for this PR.Thank you for reviewing!