Kubeflow V2 tests: normalize expected StatisticsGen image tag by TFX version#7818
Open
czgdp1807 wants to merge 1 commit intotensorflow:masterfrom
Open
Kubeflow V2 tests: normalize expected StatisticsGen image tag by TFX version#7818czgdp1807 wants to merge 1 commit intotensorflow:masterfrom
czgdp1807 wants to merge 1 commit intotensorflow:masterfrom
Conversation
…e in dag runner tests
czgdp1807
commented
Mar 5, 2026
| expected_json['pipelineSpec']['deploymentSpec'][ | ||
| 'executors']['StatisticsGen_executor'][ | ||
| 'container']['image'] = ( | ||
| f'gcr.io/tfx-oss-public/tfx:{version_utils.get_image_version()}' |
Contributor
Author
There was a problem hiding this comment.
Consider the following cases,
- If the branch being tested is
master, then,version_utils.get_image_version()will givelatest. Effectively no change. - If the branch being tested is a release branch,
r1.17.0then,version_utils.get_image_version()will give1.17.2. This will updatelatestto1.17.2which will pass the test. Currently without this PR this test fails on release branches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_compare_against_testdatato normalize expectedStatisticsGen_executor.container.imagewhen golden data usesgcr.io/tfx-oss-public/tfx:latest.version_utils.get_image_version()so expected image tags follow the version under test.