Skip to content

fix(view): add props for width and height to x-icon#1969

Open
iamdadmin wants to merge 6 commits intotempestphp:3.xfrom
iamdadmin:3.x-x-icon-default-sizing
Open

fix(view): add props for width and height to x-icon#1969
iamdadmin wants to merge 6 commits intotempestphp:3.xfrom
iamdadmin:3.x-x-icon-default-sizing

Conversation

@iamdadmin
Copy link
Contributor

Closes #1955

  • Add props for width and height to x-icon, and ability to disable it entirely so it can be set in style or class

  • Add prop for style

  • Update docs

  • Update tests

@iamdadmin
Copy link
Contributor Author

Weird, I thought that checks were set for manual trigger, I know they are going to fail as it stands as the tests aren't finished, hence leaving it in draft. Sorry, had I known they'd run I wouldn't have raised it as a draft until I had clean tests!

@iamdadmin iamdadmin changed the title fix(view): add props for width and height to x-icon fix(view): add props for width and height to x-icon Feb 13, 2026
@iamdadmin
Copy link
Contributor Author

Ready for review, I'd suggest squashing this commit as prettier which wasn't supposed to run on markdown files, ran on markdown files and really messed up the formatting, so there's some regression commits that are over the top.

@iamdadmin iamdadmin marked this pull request as ready for review February 13, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

View component x-icon defaults to 1em x 1em and doesn't include method to override this

1 participant