feat: replace local proto generation with tts-api package dependency#7
Merged
YASoftwareDev merged 5 commits intomainfrom Mar 30, 2026
Merged
feat: replace local proto generation with tts-api package dependency#7YASoftwareDev merged 5 commits intomainfrom
YASoftwareDev merged 5 commits intomainfrom
Conversation
Remove the tts-service-api git submodule and all custom setup.py build machinery (BuildPackageProtos, BuildPyGRPC, DevelopGRPC, CustomInstall, CustomEggInfo). gRPC stubs are now provided by the tts-api package. Changes: - setup.py: remove all proto-generation commands; add tts-api to install_requires (git ref until PyPI publish); fix doc URL to tts-api - pyproject.toml: remove grpcio-tools build dependency - setup.sh: remove submodule init (pre-commit only) - install.sh: remove proto sentinel check - tox.ini: switch skip_install=false + extras=test; remove manual grpcio/protobuf deps; remove commands_pre stub check - .github/workflows/test.yml: remove submodules checkout and build_grpc step - .gitmodules: deleted (no submodule) - tts_client_python/proto/__init__.py: deleted - 5 import sites updated: from tts_client_python.proto → from techmo.tts.api.v3 - CLAUDE.md: update proto stubs, setup, CI and dependency sections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tts-service-apigit submodule and all customsetup.pyproto build machinery (5 classes:BuildPackageProtos,BuildPyGRPC,DevelopGRPC,CustomInstall,CustomEggInfo)tts-apias a pip dependency (pre-built stubs fromtts-api-python)from tts_client_python.proto import techmo_tts_pb2→from techmo.tts.api.v3 import techmo_tts_pb2build_grpcstepskip_install=true+PYTHONPATHtoskip_install=false+extras=testDependency note
tts-apiis referenced via git URL until it is published to PyPI:Switch to
tts-api>=3.2.1insetup.pyonce published.Files changed
setup.pytts-apitoinstall_requires; fix doc URLpyproject.tomlgrpcio-toolsbuild depsetup.shinstall.shtox.iniskip_install=false,extras=test; remove manual deps and stub check.github/workflows/test.ymlsubmodules: recursiveandbuild_grpcstep.gitmodulestts_client_python/proto/__init__.pyfrom techmo.tts.api.v3 import …CLAUDE.mdTest plan
from techmo.tts.api.v3 import techmo_tts_pb2resolves correctly after install./install.shcompletes without proto sentinel errorpytest(unit tests) passes