perf: improve OdfTableRow cell count performance#436
Open
driesva wants to merge 1 commit intotdf:masterfrom
Open
perf: improve OdfTableRow cell count performance#436driesva wants to merge 1 commit intotdf:masterfrom
driesva wants to merge 1 commit intotdf:masterfrom
Conversation
* Issue was mentioned in tdf#25 * Do not iterate over all cells which is slow for Excel generated spreadsheets which have 16384 columns by default. * Rely on `number-columns-repeated` attribute to count the _real_ cells. * ATTN: this gives a different result for merged cells over multiple rows compared to the previous implementation. However, this count seems more in line with the actual content XML.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
number-columns-repeatedattribute to count the real cells.My test spreadsheet in LibreOffice (and Excel) looks like this:
The XML for the last 2 rows:
Based on that I would say 2 real cells and 1 real cell for the last line.
Whereas the original implementation resulted in 3 real cells for both lines ❓
👉 if the count in this PR is wrong, please provide more info!
It also doesn't fix the problem of #25 because given Excel adds rows / cells like this:
there's not really a way to know the exact number of used cells. It probably requires application logic (e.g. stop parsing at one or more empty cells / rows)