Skip to content

fix: qr code decoding error message#762

Merged
jvsena42 merged 2 commits intomasterfrom
fix/qr-code-decoding-error-message
Feb 8, 2026
Merged

fix: qr code decoding error message#762
jvsena42 merged 2 commits intomasterfrom
fix/qr-code-decoding-error-message

Conversation

@jvsena42
Copy link
Member

@jvsena42 jvsena42 commented Feb 3, 2026

Fixes #502

This PR updates the error message shown when pasting or entering unrecognized data to match the iOS behavior. Previously, Android showed "Decoding Error" / "Unable To Interpret Provided Data" while iOS shows "Unable To Read QR" / "Bitkit is not able to read this QR code."

Description

Changes the toast message for unhandled scan data in AppViewModel from other__scan_err_decoding / other__scan_err_interpret_title to other__qr_error_header / other__qr_error_text, aligning Android with iOS parity.

Preview

Screen_recording_20260203_135846.webm

QA Notes

1. Paste invalid data

  1. Copy random text (not a valid address, invoice, or LNURL)
  2. Navigate to the Send screen
  3. Paste the text into the recipient field
  4. Verify toast shows "Unable To Read QR" with description "Bitkit is not able to read this QR code."

2. Enter invalid data manually

  1. Navigate to the Send screen
  2. Type random characters into the recipient field
  3. Tap the continue/paste button
  4. Verify same error message appears

3. Regression - Valid inputs still work

  1. Paste a valid Bitcoin address - should proceed normally
  2. Paste a valid Lightning invoice - should proceed normally
  3. Scan a valid QR code - should proceed normally

@jvsena42 jvsena42 self-assigned this Feb 3, 2026
@jvsena42 jvsena42 enabled auto-merge February 3, 2026 16:54
@jvsena42 jvsena42 requested a review from ovitrif February 3, 2026 16:54
@claude

This comment has been minimized.

@claude
Copy link

claude bot commented Feb 7, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

Copy link
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@jvsena42 jvsena42 merged commit cf66055 into master Feb 8, 2026
14 checks passed
@jvsena42 jvsena42 deleted the fix/qr-code-decoding-error-message branch February 8, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Different error message in Toast when pasting (vs. iOS)

2 participants