Rename self parameter name to selfPointer#580
Open
sidepelican wants to merge 2 commits intoswiftlang:mainfrom
Open
Rename self parameter name to selfPointer#580sidepelican wants to merge 2 commits intoswiftlang:mainfrom
self parameter name to selfPointer#580sidepelican wants to merge 2 commits intoswiftlang:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to the renaming discussion at:
#572 (comment)
I have changed the parameters described as
self: jlongin various locations toselfPointer.During the process, I felt that
SwiftSelfParameter.instancehaving its own parameter name property was a source of confusion.In Swift, unlike Go, function receiver names cannot be changed, so the parameter name property is redundant information. Therefore, I have also included a change to remove it.