Skip to content

Conversation

@igor-ladkin
Copy link

Currently, when you navigate b/w different docs pages, our header is flickering and page flashes sometimes because it's plain old browser navigation and it requires repaint. Astro supports client router that makes it feel like we are in smooth SPA by utilizing page transitions api. Also moved glass morphism hook into CSS since we always have theme data attribute.

@github-actions
Copy link
Contributor

CLI Documentation Generator

Metric Value
CLI Version 0.0.1
Commands Generated 24
Tests ✅ 0/0 passed
📚 Commands documented
  • sprite login
  • sprite logout
  • sprite org auth
  • sprite org list
  • sprite org logout
  • sprite org keyring disable
  • sprite org keyring enable
  • sprite auth setup
  • sprite create
  • sprite use
  • sprite list
  • sprite destroy
  • sprite exec
  • sprite console
  • sprite checkpoint create
  • sprite checkpoint list
  • sprite checkpoint info
  • sprite checkpoint delete
  • sprite restore
  • sprite proxy
  • sprite url
  • sprite url update
  • sprite api
  • sprite upgrade

@github-actions
Copy link
Contributor

Preview Deployment

Name URL
Preview https://pr-144-superfly-sprites-docs.fly.dev

Commit: dfe78e2

@github-actions
Copy link
Contributor

Lighthouse Results

URL Performance Accessibility Best Practices SEO
/ 🟢 90 🟢 100 🟢 96 🟢 100
/cli/commands/ 🟢 98 🟢 96 🟢 100 🟢 100

@github-actions
Copy link
Contributor

E2E Test Results

✅ Tests success

Ran against: https://pr-144-superfly-sprites-docs.fly.dev

@kcmartin
Copy link
Collaborator

@kylemclaren @igor-ladkin Looks like GHA immediately commits CLI updates to the PR branch -- wouldn't it make more sense to put these in a separate PR?

Located in .github/workflows/ci.yml lines 52–67.
To have it open a separate PR instead, the else block would need to create a new branch and use gh pr create rather than pushing to github.head_ref.

The rest of the PR LGTM :)

@igor-ladkin
Copy link
Author

@kcmartin oh yeah, for sure. We should include CLI changes here, at least it was not intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants