-
Notifications
You must be signed in to change notification settings - Fork 5
Prevent header and fonts flickering #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CLI Documentation Generator
📚 Commands documented
|
Preview Deployment
Commit: |
Lighthouse Results
|
E2E Test Results✅ Tests success Ran against: https://pr-144-superfly-sprites-docs.fly.dev |
|
@kylemclaren @igor-ladkin Looks like GHA immediately commits CLI updates to the PR branch -- wouldn't it make more sense to put these in a separate PR? Located in The rest of the PR LGTM :) |
|
@kcmartin oh yeah, for sure. We should include CLI changes here, at least it was not intended. |
Currently, when you navigate b/w different docs pages, our header is flickering and page flashes sometimes because it's plain old browser navigation and it requires repaint. Astro supports client router that makes it feel like we are in smooth SPA by utilizing page transitions api. Also moved glass morphism hook into CSS since we always have theme data attribute.