Fixed #1123 Add missing Returns section in docstrings#1124
Fixed #1123 Add missing Returns section in docstrings#1124seanlaw merged 6 commits intostumpy-dev:mainfrom
Conversation
|
Review these changes at https://app.gitnotebooks.com/stumpy-dev/stumpy/pull/1124 |
|
@NimaSarajpoor I don't think I've covered all Please review at your earliest convenience. |
NimaSarajpoor
left a comment
There was a problem hiding this comment.
@seanlaw
Thanks for the PR!! I left two comments. Not relevant directly to this PR but they are related to docstring.py.
NimaSarajpoor
left a comment
There was a problem hiding this comment.
@seanlaw
I checked other changed files, and left a few comments to bring your attention to the docstrings that have out1 or out2 as the output variable name (and not out).
|
@NimaSarajpoor I think we might be good now? |
@seanlaw Nothing stands out to me! I think it is ready to be merged. Thanks for the fix!! |
See #1123
Pull Request Checklist
Below is a simple checklist but please do not hesitate to ask for assistance!
black(i.e.,python -m pip install blackorconda install -c conda-forge black)flake8(i.e.,python -m pip install flake8orconda install -c conda-forge flake8)pytest-cov(i.e.,python -m pip install pytest-covorconda install -c conda-forge pytest-cov)black --exclude=".*\.ipynb" --extend-exclude=".venv" --diff ./in the root stumpy directoryflake8 --extend-exclude=.venv ./in the root stumpy directory./setup.sh dev && ./test.shin the root stumpy directory