fix: don't emit get-value in SMT file#688
Draft
fabiomadge wants to merge 1 commit intostrata-org:mainfrom
Draft
Conversation
When using the file-based solver, (get-value) was emitted after every (check-sat). If z3 returned unsat, the subsequent (get-value) caused 'model is not available' error and z3 exited with code 1, preventing any remaining check-sat commands from executing. Pass empty variable lists to checkSat/checkSatAssuming in encodeCore so (get-value) is never written to the SMT file.
fabiomadge
force-pushed
the
fix/no-get-value-in-smt-file
branch
from
8bc9441 to
5ced8d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the file-based solver,
(get-value)was emitted after every(check-sat). If z3 returnedunsat, the subsequent(get-value)caused a "model is not available" error and z3 exited with code 1, preventing any remainingcheck-satcommands from executing.Pass empty variable lists to
checkSat/checkSatAssuminginencodeCoreso(get-value)is never written to the SMT file.