fix(SMT): restrict get-value to primitive types for cvc5 #679
Draft
fix(SMT): restrict get-value to primitive types for cvc5 #679
Conversation
cvc5 fatally aborts ("cannot get domain elements") when get-value
targets a variable of an uninterpreted sort after an unsat check-sat.
This caused spurious "Internal error" results in pyAnalyzeLaurel with
two-sided checking (--check-level full).
Filter the get-value variable list to only include nullary UFs with
primitive output types (Int, Bool, String, etc.), which are always
safe. This is conservative — datatypes are also safe, but we leave
that as a future refinement.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
shigoel
changed the title
joscoh
approved these changes
Mar 26, 2026
Contributor
|
CVC5 fixed this in their latest main branch: cvc5/cvc5#12549 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get-valuetargets a variable of an uninterpreted sort after anunsatcheck-sat-assuming, producing a "Parse Error: cannot get domain elements" and exit code 1. This prevented the second check-sat from executing, causing spurious "Internal error" results inpyAnalyzeLaurelwith--check-level full.get-valuevariable list inencodeCoreto only include nullary UFs with primitive output types (Int,Bool,String, etc.), which are always safe across both z3 and cvc5.constrtypes that don't involve uninterpreted sorts.🤖 Generated with Claude Code