Fix pagination bug causing scenes to be skipped when count < per_page#673
Open
rustyinfinity wants to merge 1 commit intostashapp:mainfrom
Open
Fix pagination bug causing scenes to be skipped when count < per_page#673rustyinfinity wants to merge 1 commit intostashapp:mainfrom
rustyinfinity wants to merge 1 commit intostashapp:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed a pagination bug in processAll() where scenes were never processed when the total scene count was less than per_page (100)
Problem
The loop used integer floor division to calculate the number of pages:
When count < per_page (e.g. 4 scenes, per_page=100):
int(4 / 100) + 1 = 0 + 1 = 1
range(1, 1) is empty — the loop never executes
No scenes are fetched or processed
Fix
Use math.ceil instead of floor division so the loop always runs at least once when there are scenes to process:
So if scenes = 4 and per_page = 100
4/100 = 0.4 then math.ceil -> 1