Skip to content

Comments

ROX-32966: Set konflux retest command alias#18917

Merged
kurlov merged 8 commits intomasterfrom
akurlov/ROX-32966-set-konflux-retest-command-alias
Feb 19, 2026
Merged

ROX-32966: Set konflux retest command alias#18917
kurlov merged 8 commits intomasterfrom
akurlov/ROX-32966-set-konflux-retest-command-alias

Conversation

@kurlov
Copy link
Member

@kurlov kurlov commented Feb 9, 2026

Description

Set konflux retest command override to avoid getting spammed by openshift-ci when konflux retest command invoked. The /retest <konflux-pipeline> will still work as before.

Github workflow changes do not have effect until it's merged to the default branch. See testing PR below to see how these changes work.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

See testing PR where this alias is merged to the default branch: stackrox/acs-fleet-manager#2573

Also tested that existing CEL conditions work as expected

Test Case                  PR                                               Pipelineruns (Exp/Act)  /retest PLRs    /konflux-retest PLRs  determine-image-tag works?
-------------------------  -----------------------------------------------  ----------------------  --------------  --------------------  --------------------------
Target release branches    https://github.com/stackrox/stackrox/pull/19019  7/7✅                   3/3✅           1/1✅                 ✅
Base branch pattern        https://github.com/stackrox/stackrox/pull/18917  7/7✅                   5/5✅           1/1✅                 ✅
Label-based triggering     https://github.com/stackrox/stackrox/pull/19028  7/7✅                   3/3✅           1/1✅                 ✅
PR draft to ready          https://github.com/stackrox/stackrox/pull/19028  0/0✅                   N/A             N/A                   N/A

I've used kubearchive for fetching pipelineruns and search was baed on commit + branch

@openshift-ci
Copy link

openshift-ci bot commented Feb 9, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions github-actions bot added area/ci konflux-build Run Konflux in PR. Push commit to trigger it. ai-review labels Feb 9, 2026
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The /konflux-retest <job>-on-push pattern is duplicated across all Tekton pipeline manifests; consider centralizing this in a shared template or generator to avoid copy‑paste drift when job names change or new pipelines are added.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The `/konflux-retest <job>-on-push` pattern is duplicated across all Tekton pipeline manifests; consider centralizing this in a shared template or generator to avoid copy‑paste drift when job names change or new pipelines are added.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Feb 9, 2026

Images are ready for the commit at 27fb4ba.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-104-g27fb4ba1c5.

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.51%. Comparing base (300a724) to head (27fb4ba).
⚠️ Report is 51 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #18917      +/-   ##
==========================================
- Coverage   49.52%   49.51%   -0.01%     
==========================================
  Files        2666     2670       +4     
  Lines      201181   201549     +368     
==========================================
+ Hits        99629    99801     +172     
- Misses      94115    94294     +179     
- Partials     7437     7454      +17     
Flag Coverage Δ
go-unit-tests 49.51% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kurlov kurlov marked this pull request as ready for review February 10, 2026 12:50
@kurlov kurlov requested review from a team and rhacs-bot as code owners February 10, 2026 12:50
@rhacs-bot rhacs-bot requested a review from a team February 10, 2026 12:50
@stackrox stackrox deleted a comment from openshift-ci bot Feb 10, 2026
@stackrox stackrox deleted a comment from openshift-ci bot Feb 10, 2026
@stackrox stackrox deleted a comment from openshift-ci bot Feb 10, 2026
@stackrox stackrox deleted a comment from openshift-ci bot Feb 10, 2026
@stackrox stackrox deleted a comment from github-actions bot Feb 12, 2026
@stackrox stackrox deleted a comment from github-actions bot Feb 12, 2026
@github-actions
Copy link
Contributor

/retest scanner-v4-db-on-push

@github-actions
Copy link
Contributor

/retest operator-bundle-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Feb 13, 2026
@stackrox stackrox deleted a comment from openshift-ci bot Feb 13, 2026
@github-actions
Copy link
Contributor

/retest central-db-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Feb 13, 2026
@github-actions
Copy link
Contributor

/retest main-on-push

@github-actions
Copy link
Contributor

/retest operator-bundle-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Feb 17, 2026
@stackrox stackrox deleted a comment from openshift-ci bot Feb 17, 2026
@kurlov kurlov requested a review from msugakov February 17, 2026 11:45
@kurlov
Copy link
Member Author

kurlov commented Feb 19, 2026

/konflux-retest main-on-push

@kurlov
Copy link
Member Author

kurlov commented Feb 19, 2026

/konflux-retest operator-bundle-on-push

@kurlov
Copy link
Member Author

kurlov commented Feb 19, 2026

/konflux-retest create-custom-snapshot

@kurlov
Copy link
Member Author

kurlov commented Feb 19, 2026

/konflux-retest operator-bundle-on-push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review area/ci area/scanner konflux-build Run Konflux in PR. Push commit to trigger it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants