Split rpm/deb vars into different files

[Alex-Welsh]

This change is a noop, it just splits up the very long "package-repos" file into deb/rpm/universal files for better maintainability

[gemini-code-assist]

Summary of Changes

Hello @Alex-Welsh, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the Ansible inventory by reorganizing package repository definitions. The existing large 'package-repos' file has been logically separated into distinct files for Debian and RPM-specific configurations, alongside a file for universal settings. This structural improvement is intended to make the configuration easier to navigate and maintain without introducing any changes to the system's operational behavior.

Highlights

• File Refactoring: The monolithic 'package-repos' file has been split into separate files for Debian, RPM, and universal package repository configurations.
• Improved Maintainability: This change aims to enhance the maintainability of package repository definitions by organizing them into more manageable, specific files.
• No Functional Change: The pull request explicitly states that this is a no-op change, meaning there is no alteration to the functional behavior of the package repository configurations.

Changelog

• ansible/inventory/group_vars/all/deb-package-repos
  • Added new file containing all Debian package repository definitions, extracted from the original 'package-repos' file.
• ansible/inventory/group_vars/all/package-repos
  • Removed Debian and RPM package repository definitions, retaining only the universal package synchronization group variable.
• ansible/inventory/group_vars/all/rpm-package-repos
  • Added new file containing all RPM package repository definitions, extracted from the original 'package-repos' file.

Activity

• No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the package repository variables by splitting them into separate files for deb, rpm, and universal configurations. This is a good change for maintainability. I've found a few issues:

• A critical bug where component is used instead of components in one of the deb repository definitions.
• Several repository URLs use insecure http instead of https.
• Some documentation comments in the new files are incomplete, missing keys that are used in the repository definitions.

I've added specific comments with suggestions to address these points.

[priteau]

Please add missing new line at end of file.