DNM: Rebuild nova with Ironic rebuild fix#2165
DNM: Rebuild nova with Ironic rebuild fix#2165jovial wants to merge 3 commits intostackhpc/2024.1from
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the configuration to use a specific bugfix version of Nova and pins Python dependency constraints to a specific commit. While these changes are effective for testing the intended fix, they introduce long-term maintainability concerns. The review includes suggestions to use stable branches or tags for dependencies before this change is merged to ensure the solution is robust and maintainable.
| nova-base: | ||
| type: git | ||
| location: https://github.com/stackhpc/nova.git | ||
| reference: bugfix/2024.1/ironic-rebuild |
There was a problem hiding this comment.
Using a bugfix branch for nova-base is suitable for testing, but it introduces a risk for long-term maintenance if merged as-is. For a production-ready state, this reference should point to a stable release tag or branch once the fix has been integrated there.
| # Default value is | ||
| # "https://releases.openstack.org/constraints/upper/{{ openstack_release }}" | ||
| pip_upper_constraints_file: "https://raw.githubusercontent.com/stackhpc/requirements/refs/heads/stackhpc/{{ openstack_release }}/upper-constraints.txt" | ||
| pip_upper_constraints_file: "https://raw.githubusercontent.com/stackhpc/requirements/5306218480b90c3b97b57431e22b5b8bcb67ef81/upper-constraints.txt" |
There was a problem hiding this comment.
Pinning the pip_upper_constraints_file to a specific commit hash improves reproducibility but prevents automatic updates from the source branch, including potential security fixes. If this change is intended to be temporary for testing this bugfix, it should be reverted to use the dynamic stackhpc/{{ openstack_release }} branch before merging to simplify future maintenance.
1 participant
No description provided.