Caracal upgrade to Rocky Linux 9.7

[elelaysh]

• DOCA ofed 3.2.1 is needed for RL 9.7

Also see #2025

[gemini-code-assist]

Code Review

This pull request introduces a wide range of changes to support Rocky Linux 9.7 and upgrade various components. The changes include updates to package versions, container image tags, Ansible playbooks, documentation, and CI configuration. Notably, there's a significant effort to add multi-architecture support, refactor secret store deployment playbooks into a unified set, and improve the logic for fixing OVN chassis priorities. The addition of numerous release notes is a great practice. I have a few suggestions for improvement regarding a hardcoded value in an alerting rule, a dependency pointing to a temporary branch, and a long inline script that could be refactored for better maintainability. Overall, this is a substantial and well-executed upgrade.

I am having trouble creating individual review comments. Click here to see my feedback.

etc/kayobe/kolla/config/prometheus/rabbitmq.rules (23)

The number of RabbitMQ nodes in this alert expression is hardcoded to 3. This seems to be a regression, as a variable (alertmanager_number_of_rabbitmq_nodes) was likely used before, and is still used for another alert in this file. Hardcoding this value may cause incorrect alerts if the number of RabbitMQ nodes is different from 3. Please consider restoring the use of a variable to determine the number of nodes dynamically.

etc/kayobe/kolla/kolla-build.conf (18)

The openstack-base source is pointing to a temporary branch bp/bump-django-4.2/2024.1. This is risky for long-term maintainability as temporary branches may be deleted. It's better to point to a stable tag or branch. If this is a temporary measure, it would be good to add a comment explaining the situation and when it can be reverted.

etc/kayobe/ansible/ovn-fix-chassis-priorities.yml (55-160)

The shell script in this task is very long and complex. Embedding large scripts directly in Ansible playbooks makes them difficult to read, maintain, and test. Consider moving this script to a separate file within the repository (e.g., in a files/ or scripts/ directory) and executing it by copying it to the target container and running it with ansible.builtin.command. This would improve readability and maintainability of the playbook.