Conversation
jgravois
commented
Mar 29, 2026
| export { Arc } from './arc.js'; | ||
| export { GreatCircle } from './great-circle.js'; | ||
| export { roundCoords, D2R, R2D } from './utils.js'; | ||
| export { _LineString } from './line-string.js'; |
Collaborator
Author
There was a problem hiding this comment.
based on the filename, i'm guessing that it'd be preferable to stop exporting _LineString publicly.
Collaborator
Author
There was a problem hiding this comment.
since the package.json has a files whitelist, i'm pretty sure the .npmignore blacklist is irrelevant/redundant.
Comment on lines
+342
to
+343
| <button id="clear" class="btn">Clear All</button> | ||
| <button id="reset" class="btn btn-danger">Reset View</button> |
Collaborator
Author
There was a problem hiding this comment.
since modules avoid polluting the global scope, we have to wire up the click handlers slightly differently.
|
|
||
| <script> | ||
| <script type="module"> | ||
| import { GreatCircle } from 'https://cdn.skypack.dev/arc@1'; |
Collaborator
Author
There was a problem hiding this comment.
this won't work until we actually publish v1.0.0.
in the interim, either of the two below should work:
import { GreatCircle } from 'https://cdn.skypack.dev/-/arc@v1.0.0-beta.1';
import { GreatCircle } from './dist/index.js';
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as originally suggested in #34 (comment)
@thomas-hervey can you take v1.0.0-beta.1 for a spin in turf and let me know if you run into any problems?