Skip to content

chore: stop tracking files compiled by TS and advertise node@16 as the min supported runtime#73

Merged
jgravois merged 2 commits intomainfrom
chore/ts-cleanup
Mar 28, 2026
Merged

chore: stop tracking files compiled by TS and advertise node@16 as the min supported runtime#73
jgravois merged 2 commits intomainfrom
chore/ts-cleanup

Conversation

@jgravois
Copy link
Copy Markdown
Collaborator

@jgravois jgravois commented Mar 27, 2026

once we land #69 and this one, i'm in favor of publishing arc.js@1.0.0.

technically tests are only failing in 14.x because jest itself calls String.replaceAll(), but given that we're targeting ES2022, 16x (which end-of-lifed back in 08/2023) feels like a sensible baseline to me.

ref: https://www.reddit.com/r/typescript/comments/ygqhle/comment/iua3nx8/

@jgravois jgravois changed the title chore: stop tracking files compiled by TS and advertise Node.js@14 as the minimum supported runtime chore: stop tracking files compiled by TS and advertise node@16 as the min supported runtime Mar 27, 2026
@jgravois jgravois marked this pull request as ready for review March 27, 2026 03:26
@springmeyer
Copy link
Copy Markdown
Owner

Would you be up for doing the release (and doing a pre-release first like a v1.0.0-alpha to ensure it can be installed and works correctly)?

Copy link
Copy Markdown
Owner

@springmeyer springmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks so much. Only question is whether the root ./arc.js might be depended upon by downstream users? That said I'm okay with v1.0.0 being breaking if it is clearly documented how to upgrade.

@jgravois
Copy link
Copy Markdown
Collaborator Author

jgravois commented Mar 27, 2026

Only question is whether the root ./arc.js might be depended upon by downstream users?

this PR is definitely backwards-compatible.

I'm okay with v1.0.0 being breaking if it is clearly documented how to upgrade.

if you're not opposed to breaking a few eggs 🍳, i'd argue that dropping the CJS build altogether is an idea that has merit. folks like @sindresorhus have championed native ESM packages for years.

i'd just want to confirm that turf's own build tooling and testing framework support pure ESM dependencies (it appears that they do), before proposing the change in a separate PR.

Would you be up for doing the release (and doing a pre-release first like a v1.0.0-alpha to ensure it can be installed and works correctly)?

for sure. i can publish 0.2.1 first if you're not opposed to me exploring the idea above ☝️. that would ensure that #69 makes it into the wild in a release that folks that still need CJS can use.

you may already know about this, but npm pack is also a really handy command to dry run before publishing an immutable version.

edit: haha. I'm just parroting something I already said in 2024.

@springmeyer
Copy link
Copy Markdown
Owner

Thanks! Yeah, go for it.

@jgravois jgravois merged commit f3a89a7 into main Mar 28, 2026
8 checks passed
@jgravois jgravois deleted the chore/ts-cleanup branch March 28, 2026 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants