Support elision for flat line trees#300
Closed
gschlager wants to merge 1 commit intosplitwise:mainfrom
Closed
Conversation
This was referenced Feb 5, 2026
jas14
reviewed
Feb 10, 2026
Collaborator
jas14
left a comment
jas14
left a comment
There was a problem hiding this comment.
Thanks @gschlager ! I'm hoping to sit down and review this on Friday. In the meantime, you can address the lint failures so the rest of the test suite runs.
gschlager
force-pushed
the
elision-line-count
branch
2 times, most recently
from
803800d to
e35c46a
Compare
gschlager
force-pushed
the
elision-line-count
branch
from
e35c46a to
d9f1d92
Compare
jas14
added a commit
that referenced
this pull request
Feb 14, 2026
While reviewing #300, I noticed some unrelated clean-up opportunities in `TieredLinesElider`. Most importantly, `Pane#padded` was essentially a no-op. This PR gets rid of it, and simplifies up the call stack through `TieredLinesElider#panes`. Less importantly, and more for my own satisfaction, `#filter_out_boxes_fully_contained_in_others` was $O(n^2)$; assuming sorting is sub-quadratic, it's also now sub-quadratic.
jas14
approved these changes
Feb 14, 2026
Collaborator
|
Merged in f70439b. :) |
jas14
added a commit
to gschlager/super_diff
that referenced
this pull request
Feb 14, 2026
While reviewing splitwise#300, I noticed some unrelated clean-up opportunities in `TieredLinesElider`. Most importantly, `Pane#padded` was essentially a no-op. This PR gets rid of it, and simplifies up the call stack through `TieredLinesElider#panes`. Less importantly, and more for my own satisfaction, `#filter_out_boxes_fully_contained_in_others` was $O(n^2)$; assuming sorting is sub-quadratic, it's also now sub-quadratic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.