Skip to content

Fix integration snippet indentation #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jas14 merged 2 commits into from
Feb 14, 2026
Merged

Fix integration snippet indentation #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20a8099
Fix integration snippet indentation
gschlager Feb 5, 2026
19c4bcc
Add CHANGELOG entry
jas14 Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
- Remove unused `syntax_tree` gems from development. [#297](https://github.com/splitwise/super_diff/pull/297)
- Simplify tiered lines elider. [#302](https://github.com/splitwise/super_diff/pull/302)
- Support elision for flat line trees. [#300](https://github.com/splitwise/super_diff/pull/300)
- Fix integration snippet indentation. [#299](https://github.com/splitwise/super_diff/pull/299)

## 0.18.0 - 2025-12-05

Expand Down
2 changes: 1 addition & 1 deletion spec/support/integration/test_programs/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def minimal_program
opt_before = RSpec::Expectations.configuration.on_potential_false_positives
begin
RSpec::Expectations.configuration.on_potential_false_positives = :nothing
#{reindent(code, level: 3)}
#{reindent(code, level: 3)}
Copy link
Collaborator

@jas14 jas14 Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, I previously tried to fiddle with level, including adjusting to 2, which didn't fix it. And now I see that it's because it might make the first line indented correctly, but the subsequent ones in code wouldn't be.

ensure
RSpec::Expectations.configuration.on_potential_false_positives = opt_before
end
Expand Down