Index SCIP field enclosing_range#838
Merged
jupblb merged 3 commits intosourcegraph:mainfrom Feb 13, 2026
Merged
Conversation
Contributor
Author
|
Issues that I don't know how to fix for now:
|
f1e75e6 to
9f95a07
Compare
Contributor
Author
|
Updated snapshots by first updating ScipPrinters.scala, then |
153a1e9 to
503d626
Compare
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
- Add 2-space prefix to all source lines in snapshot output, matching the convention used by scip-go snapshots for caret-based indicators - Convert tab indentation to 2-space indentation in test input files: TabIndented.java, AnnotationParameters.java, LombokBuilder.java
…tyle Replace inline 'enclosing_range 3 2 5 3' format with visual marker lines: - '⌄ enclosing_range_start <symbol>' before the source line - '⌃ enclosing_range_end <symbol>' after the source line Also fix SemanticdbVisitor to only compute enclosing ranges for definition occurrences, not references (matching the original intent of commit 9f95a07).
503d626 to
2b90796
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #833