-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Parameter Store 기반 설정 관리 전환 및 loadtest 프로필 추가 #670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
9d67065
8f0d17c
baa7977
8948dad
74f8f3b
1c8cb90
2ff0c37
2ecf68c
ea18274
f112420
58b9ff3
730068c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| spring: | ||
| config: | ||
| activate: | ||
| on-profile: loadtest | ||
|
|
||
| jpa: | ||
| show-sql: false | ||
| properties: | ||
| hibernate: | ||
| format_sql: false | ||
|
|
||
| datasource: | ||
| hikari: | ||
| maximum-pool-size: 50 | ||
| minimum-idle: 20 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 부하 테스트시에는 flyway 사용 안 하니까 명시적으로
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 확인했습니당 |
||
|
|
||
| flyway: | ||
| enabled: false | ||
|
|
||
| websocket: | ||
| thread-pool: | ||
| inbound: | ||
| core-pool-size: 24 | ||
| max-pool-size: 48 | ||
| queue-capacity: 4000 | ||
| outbound: | ||
| core-pool-size: 24 | ||
| max-pool-size: 48 | ||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| queue-capacity: 4000 | ||
| heartbeat: | ||
| server-interval: 10000 | ||
| client-interval: 10000 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| spring: | ||
| config: | ||
| activate: | ||
| on-profile: local, dev, prod, loadtest | ||
|
|
||
| cloud: | ||
| aws: | ||
| stack: | ||
| auto: false |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| --- | ||
| spring: | ||
| config: | ||
| activate: | ||
| on-profile: prod | ||
|
|
||
| jpa: | ||
| hibernate: | ||
| ddl-auto: none | ||
| generate-ddl: false | ||
| show-sql: false | ||
| database: mysql | ||
| defer-datasource-initialization: false | ||
|
|
||
| datasource: | ||
| driverClassName: com.mysql.cj.jdbc.Driver | ||
|
|
||
| flyway: | ||
| enabled: true | ||
| locations: classpath:db/migration | ||
| baseline-on-migrate: false | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 기존에는
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. baseline을 true로 할 이유가 없다고 판단했습니다! 지금 어차피 flyway적용 중인 상태라 DB를 옮기는 게 아니면 baseline이 거의 필요 없는 상황이라서요! DB를 옮기는 등 특수한 상황이면 수동으로 실행하는 게 안전하다고 생각했습니당 |
||
|
|
||
| --- | ||
| spring: | ||
| config: | ||
| activate: | ||
| on-profile: dev | ||
|
|
||
| jpa: | ||
| hibernate: | ||
| ddl-auto: validate | ||
| generate-ddl: false | ||
| show-sql: false | ||
| database: mysql | ||
| defer-datasource-initialization: false | ||
|
|
||
| datasource: | ||
| driverClassName: com.mysql.cj.jdbc.Driver | ||
|
|
||
| flyway: | ||
| enabled: true | ||
| locations: classpath:db/migration | ||
| baseline-on-migrate: false | ||
|
|
||
| --- | ||
| spring: | ||
| config: | ||
| activate: | ||
| on-profile: local | ||
|
|
||
| jpa: | ||
| hibernate: | ||
| ddl-auto: create | ||
| generate-ddl: true | ||
| show-sql: true | ||
| database: mysql | ||
| defer-datasource-initialization: true | ||
| properties: | ||
| hibernate: | ||
| format_sql: true | ||
|
|
||
| sql: | ||
| init: | ||
| mode: always | ||
|
|
||
| datasource: | ||
| driverClassName: com.mysql.cj.jdbc.Driver | ||
|
|
||
| flyway: | ||
| enabled: false | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,154 @@ | ||
| view: | ||
| count: | ||
| scheduling: | ||
| delay: 3000 | ||
|
|
||
| websocket: | ||
| thread-pool: | ||
| inbound: | ||
| core-pool-size: 6 | ||
| max-pool-size: 12 | ||
| queue-capacity: 1000 | ||
| outbound: | ||
| core-pool-size: 6 | ||
| max-pool-size: 12 | ||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| queue-capacity: 1000 | ||
| heartbeat: | ||
| server-interval: 15000 | ||
| client-interval: 15000 | ||
|
|
||
| oauth: | ||
| apple: | ||
| token-url: "https://appleid.apple.com/auth/token" | ||
| client-secret-audience-url: "https://appleid.apple.com" | ||
| public-key-url: "https://appleid.apple.com/auth/keys" | ||
| kakao: | ||
| token-url: "https://kauth.kakao.com/oauth/token" | ||
| user-info-url: "https://kapi.kakao.com/v2/user/me" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 사소하긴 한데요, test 설정 파일에는
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 통일하겠습니당 |
||
|
|
||
| sentry: | ||
| send-default-pii: false | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 기존에는
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이거 보안이랑 개인정보 관련해서 좀 민감한 부분이라 일단 false로 돌렸습니당... 실무에서도 필요한 필드만 따로 설정해서 수동 전송한다고 하더라구요 |
||
| traces-sample-rate: 1.0 | ||
| exception-resolver-order: -2147483647 | ||
|
|
||
| management: | ||
| server: | ||
| port: 8081 | ||
|
|
||
| token: | ||
| access: | ||
| storage-key-prefix: "ACCESS" | ||
| expire-time: 1h | ||
| refresh: | ||
| storage-key-prefix: "REFRESH" | ||
| expire-time: 90d | ||
| sign-up: | ||
| storage-key-prefix: "SIGN_UP" | ||
| expire-time: 10m | ||
| black-list: | ||
| storage-key-prefix: "BLACKLIST" | ||
| expire-time: 1h | ||
|
|
||
| --- | ||
| spring: | ||
| config: | ||
| activate: | ||
| on-profile: prod | ||
|
|
||
| websocket: | ||
| thread-pool: | ||
| inbound: | ||
| core-pool-size: 16 | ||
| max-pool-size: 32 | ||
| queue-capacity: 2000 | ||
| outbound: | ||
| core-pool-size: 16 | ||
| max-pool-size: 32 | ||
| queue-capacity: 2000 | ||
| heartbeat: | ||
| server-interval: 10000 | ||
| client-interval: 10000 | ||
|
|
||
| cors: | ||
| allowed-origins: | ||
| - "https://www.solid-connection.com" | ||
| - "https://api.solid-connection.com" | ||
| - "https://admin.solid-connection.com" | ||
|
|
||
| sentry: | ||
| environment: "production" | ||
| traces-sample-rate: 0.1 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이전에는 prod에도 sentry trace rate가 1.0이었는데, 0.1로 변경하신 이유가 있나요 ?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 1.0은 오버헤드가 크다고해서 줄여봤습니다...! 실무에서는 보통 0.05~0.2를 사용한다고 하네요 문제 있으면 수정하겠습니다!
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 그대로 가도 좋을 거 같아요 ! |
||
|
|
||
| token: | ||
| refresh: | ||
| cookie-domain: ".solid-connection.com" | ||
|
|
||
| --- | ||
| spring: | ||
| config: | ||
| activate: | ||
| on-profile: dev | ||
|
|
||
| websocket: | ||
| thread-pool: | ||
| inbound: | ||
| core-pool-size: 4 | ||
| max-pool-size: 8 | ||
| queue-capacity: 500 | ||
| outbound: | ||
| core-pool-size: 4 | ||
| max-pool-size: 8 | ||
| queue-capacity: 500 | ||
| heartbeat: | ||
| server-interval: 15000 | ||
| client-interval: 15000 | ||
|
|
||
| cors: | ||
| allowed-origins: | ||
| - "https://www.stage.solid-connection.com" | ||
| - "https://api.stage.solid-connection.com" | ||
| - "https://www.stage.admins.solid-connection.com" | ||
| - "http://localhost:3000" | ||
| - "https://localhost:3000" | ||
| - "http://localhost:5173" | ||
|
|
||
| sentry: | ||
| environment: "dev" | ||
|
|
||
| token: | ||
| refresh: | ||
| cookie-domain: ".stage.solid-connection.com" | ||
|
|
||
| --- | ||
| spring: | ||
| config: | ||
| activate: | ||
| on-profile: local | ||
|
|
||
| websocket: | ||
| thread-pool: | ||
| inbound: | ||
| core-pool-size: 4 | ||
| max-pool-size: 8 | ||
| queue-capacity: 500 | ||
| outbound: | ||
| core-pool-size: 4 | ||
| max-pool-size: 8 | ||
| queue-capacity: 500 | ||
| heartbeat: | ||
| server-interval: 15000 | ||
| client-interval: 15000 | ||
|
|
||
| cors: | ||
| allowed-origins: | ||
| - "http://localhost:8080" | ||
| - "http://localhost:3000" | ||
| - "http://localhost:5173" | ||
| - "https://localhost:3000" | ||
|
|
||
| sentry: | ||
| environment: "development" | ||
|
|
||
| token: | ||
| refresh: | ||
| cookie-domain: "localhost" | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker compose에 리전을 추가하셨는데, EC2의 리전을 추론하도록 하면 어떤 차이가 있을까요 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
명시 안했을 때 이점이 인프라 리전 변경했을 때 자동추론 밖에 없는데 그냥 명시하는 게 안정적일 것 같아 명시했습니다!