Skip to content

Comments

fix: Fixes handling of recursive type aliases#210

Merged
Daverball merged 3 commits intomainfrom
fix/recursive-type-aliases
Feb 18, 2026
Merged

fix: Fixes handling of recursive type aliases#210
Daverball merged 3 commits intomainfrom
fix/recursive-type-aliases

Conversation

@Daverball
Copy link
Collaborator

Closes #209

Handling of recursive type aliases was broken, since the symbol was registered lexicographically before where the use occurs. We've worked around this by using node.end_lineno and node.end_col_offset of the AnnAssign statement instead, which should be a little bit more robust.

@Daverball Daverball merged commit 5d63c1f into main Feb 18, 2026
6 checks passed
@Daverball Daverball deleted the fix/recursive-type-aliases branch February 18, 2026 22:48
@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.5%. Comparing base (966749f) to head (6a9293d).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #210     +/-   ##
=======================================
+ Coverage   96.4%   96.5%   +0.1%     
=======================================
  Files          4       4             
  Lines        968     968             
=======================================
+ Hits         934     935      +1     
+ Misses        34      33      -1     
Files with missing lines Coverage Δ
flake8_type_checking/checker.py 96.2% <ø> (+0.1%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TC003 and TC008 false positives for TypeAlias

1 participant