Skip to content

Enabling stdinput in the style of FastQC#89

Open
kerrycobb wants to merge 1 commit intosmithlabcode:masterfrom
kerrycobb:stdin
Open

Enabling stdinput in the style of FastQC#89
kerrycobb wants to merge 1 commit intosmithlabcode:masterfrom
kerrycobb:stdin

Conversation

@kerrycobb
Copy link

A feature of FastQC that is missing from falco is the ability to use stdin as input. I made a few changes to allow it to be done in the style of FastQC like cat <fastq files> | falco stdin:<prefix>.

I haven't tested it extensively but at a glance it looks like it's working with fastqc files. It assumes fastq format. I'm not sure how FastQC accomodates other formats as stdin. Perhaps with the --format flag.

I don't have much time right now to keep working on this. My fork is doing what I needed. Maybe this can inspire or help you to implement this feature. If you are receptive, I may be able to put some more effort in at some point to make this more robust and add some tests.

@andrewdavidsmith
Copy link
Collaborator

andrewdavidsmith commented Mar 14, 2026

@kerrycobb Thanks for this. I appreciate the help. I won't be able to get to this for at least a week. Is there any chance you can update the test/falco.test script to add something that would cover this new kind of input? I'm not sure if you ran the make check after building with the autotools build. On my end I'll need time to run all of the things in the benchmark dir (using run_all_falco_tests.sh only) with the master branch vs. your PR and check that all files are the same except dates and times. Regarding the falco.test script, I think it's designed to cover types of inputs, rather than user args settings, so maybe a separate test script would be warranted, which would then appear in the line starting with TEST in Makefile.am.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants