feat: Add a plugin that records Sli total amount rules#773
Open
mimitantono wants to merge 2 commits intoslok:mainfrom
Open
feat: Add a plugin that records Sli total amount rules#773mimitantono wants to merge 2 commits intoslok:mainfrom
mimitantono wants to merge 2 commits intoslok:mainfrom
Conversation
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This merge request adds a new Sloth SLO plugin that generates Prometheus recording rules for the total SLI amount, preserving the TotalQuery defined in the SLO spec.
The plugin emits the metric slo:sli_total:amount and is designed to be used as part of Sloth’s existing plugin chain.
Motivation
Sloth currently derives ratios and burn rates but does not expose the raw total SLI amount. Recording this value explicitly improves debuggability, traffic correlation, and reuse of the original TotalQuery without duplication or drift.
Behavior