fix: add dark mode support to macOS pkg installer#13
Merged
christiangda merged 1 commit intomainfrom Mar 22, 2026
Merged
Conversation
Text and code blocks were unreadable when macOS was set to dark mode because all colors were hardcoded for light backgrounds. Add prefers-color-scheme media queries and color-scheme meta tag to welcome, readme, and license pages. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@media (prefers-color-scheme: dark)styles to all three installer HTML pages (welcome, readme, license) so text, code blocks, tables, and links are readable in dark mode<meta name="color-scheme" content="light dark">to explicitly declare dual-scheme support, ensuring the WebView applies correct default backgrounds and adapts native UI elementsTest plan
.pkginstaller and run it on macOS with light appearance — verify no visual regression🤖 Generated with Claude Code