Skip to content

Comments

feat(experiment): add charm prompts to iostreams#350

Merged
zimeg merged 2 commits intomainfrom
charm-iostreams
Feb 24, 2026
Merged

feat(experiment): add charm prompts to iostreams#350
zimeg merged 2 commits intomainfrom
charm-iostreams

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Feb 24, 2026

Summary

This PR adds charm prompts to the iostreams package as an option for prompts when the charm experiment is on! 🍀

For kind discussion of #349 📺 ✨

Reviewers

Attempt a few commands to find various options appear:

$ slack create asdf -e charm  # Automation app > Deno Slack SDK
$ cd asdf
$ slack deploy -e charm
$ slack env add -e charm
$ slack delete -e charm

This shows select options, text inputs, and confirmation!

Requirements

@zimeg zimeg self-assigned this Feb 24, 2026
@zimeg zimeg added enhancement M-T: A feature request for new functionality experiment Experimental feature accessed behind the --experiment flag or toggle semver:patch Use on pull requests to describe the release version increment labels Feb 24, 2026
@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 4.76190% with 80 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.44%. Comparing base (62770ba) to head (952c731).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/iostreams/charm.go 0.00% 65 Missing ⚠️
internal/iostreams/survey.go 0.00% 10 Missing ⚠️
internal/pkg/auth/login.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
- Coverage   64.62%   64.44%   -0.18%     
==========================================
  Files         212      213       +1     
  Lines       17820    17879      +59     
==========================================
+ Hits        11517    11523       +6     
- Misses       5225     5281      +56     
+ Partials     1078     1075       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@srtaalej srtaalej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woah! great idea adding charm to the iostreams package! this make this migration so much easier 😁 testing went well for me - the cli is looking beauuuuuuutiful 🤩

@zimeg zimeg marked this pull request as ready for review February 24, 2026 20:06
@zimeg zimeg requested a review from a team as a code owner February 24, 2026 20:06
@zimeg zimeg added this to the Next Release milestone Feb 24, 2026
@zimeg
Copy link
Member Author

zimeg commented Feb 24, 2026

@srtaalej Credit to claude and perhaps earlier refactors to prompt from iostreams helped so much! 👾 ✨

Thanks so much for the review! I agree this is a fast approach to bringing these prompts to most surfaces, but let's continue to improve how some experiences appear - I find create lags when selecting "samples" for example. And perhaps we explore themes more soon 🎨

Let's get this merged behind the charm experiment for now! 🚢 💨

@zimeg zimeg merged commit 1059ec2 into main Feb 24, 2026
8 checks passed
@zimeg zimeg deleted the charm-iostreams branch February 24, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality experiment Experimental feature accessed behind the --experiment flag or toggle semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants