chore: update pyproject.toml with [project] section#71
Conversation
| [project] | ||
| name = "bolt-python-starter-template" | ||
| version = "0.1.0" | ||
| requires-python = ">=3.11" |
There was a problem hiding this comment.
note: I went with 3.11 because it's the min version our Workflow tests.
mwbrooks
changed the title
mwbrooks
changed the title
mwbrooks
added
enhancement
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
@mwbrooks LGTM and thanks for bringing this project to latest standards oncemore 🚀 ✨
I'm leaving a comment about requirements.txt that might be related to this changeset but shouldn't block changes otherwise! Thanks for finding these update 📠
| [project.optional-dependencies] | ||
| dev = [ | ||
| "pytest==9.0.2", | ||
| "ruff==0.9.4", | ||
| ] |
There was a problem hiding this comment.
🪓 question: Can we remove requirements.txt alongside these additions?
IIRC the pyproject.toml is recommended as standard for dependencies?
It’s important to be clear that pip determines package dependencies using the project metadata (typically in
pyproject.tomlorsetup.py), not by discoveringrequirements.txtfiles embedded in projects.
🔗 https://pip.pypa.io/en/latest/user_guide/#requirements-files
WilliamBergamin
left a comment
WilliamBergamin
left a comment
There was a problem hiding this comment.
Thanks for working on this 💯
Similar comments as @zimeg non blocking though!
| @@ -1,3 +1,17 @@ | |||
| [project] | |||
| name = "bolt-python-starter-template" | |||
| version = "0.1.0" | |||
| [project.optional-dependencies] | ||
| dev = [ | ||
| "pytest==9.0.2", | ||
| "ruff==0.9.4", | ||
| ] |
3 participants
Type of change
Summary
This pull request update
pyproject.tomlwith a[project]section anddependenciesarray.This is important for developers running
pip install -e .. Without a project section and dependencies array, an error is returned.Requirements