Add codespell (config, precommit, workflow) and make it fix typos#670
Draft
yarikoptic wants to merge 7 commits intosingularityhub:mainfrom
Draft
Add codespell (config, precommit, workflow) and make it fix typos#670yarikoptic wants to merge 7 commits intosingularityhub:mainfrom
yarikoptic wants to merge 7 commits intosingularityhub:mainfrom
Conversation
Otherwise black does not work
❯ black shpc/client/__init__.py
Invalid config keys detected: 'profile' (in /home/yoh/proj/misc/singularity-hpc/pyproject.toml)
Usage: black [OPTIONS] SRC ...
Try 'black -h' for help.
Error: Config key exclude must be a string
❯ black --version
black, 24.2.0 (compiled: yes)
Python (CPython) 3.11.8
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w || :",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w -i 3 -C 2",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
Author
|
found this one without comments -- any interest for me to refresh/finish? there is still some typos left: |
Member
|
If you have interest! I didn't comment because it's marked as a Draft. Let me know when it's ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO