fix(function): isolated-vm worker pool to prevent single-worker bottleneck#3155
Open
waleedlatif1 wants to merge 2 commits intostagingfrom
Open
fix(function): isolated-vm worker pool to prevent single-worker bottleneck#3155waleedlatif1 wants to merge 2 commits intostagingfrom
waleedlatif1 wants to merge 2 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
@cursor review |
Contributor
Greptile OverviewGreptile Summary
Confidence Score: 3/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Caller as Caller
participant Pool as isolated-vm.ts
participant Worker as Child worker
participant VM as isolated-vm-worker.cjs
Caller->>Pool: "executeInIsolatedVM(req)"
alt "totalActiveExecutions >= MAX_CONCURRENT"
Pool->>Pool: "enqueueExecution(req)"
else "capacity available"
Pool->>Pool: "acquireWorker()"
alt "existing worker found"
Pool->>Worker: "dispatchToWorker(req)"
else "spawn new worker"
Pool->>Worker: "spawnWorker()"
Worker->>VM: "spawn node isolated-vm-worker.cjs"
VM-->>Worker: "IPC ready"
Pool->>Worker: "dispatchToWorker(req)"
else "all saturated"
Pool->>Pool: "enqueueExecution(req)"
end
end
Worker->>VM: "IPC execute(executionId, request)"
opt "VM requests fetch"
VM-->>Pool: "IPC fetch(fetchId, url, optionsJson)"
Pool->>Pool: "secureFetch(validateProxyUrl + fetch)"
Pool-->>VM: "IPC fetchResponse(fetchId, response)"
end
VM-->>Pool: "IPC result(executionId, result)"
Pool->>Pool: "decrement counts + reset idle timeout"
Pool->>Pool: "drainQueue()"
opt "worker idle"
Pool->>Worker: "cleanupWorker() after idle timeout"
end
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually. Existing vitest suite (30 tests) passes unchanged.
Checklist