Skip to content

SF-3513 Add pre-compressed Brotli support to Kestrel#3722

Merged
RaymondLuong3 merged 1 commit intomasterfrom
fix/SF-3513
Mar 3, 2026
Merged

SF-3513 Add pre-compressed Brotli support to Kestrel#3722
RaymondLuong3 merged 1 commit intomasterfrom
fix/SF-3513

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Mar 3, 2026

This PR adds Brotli support to Kestrel, as Apache passes static file requests straight through to Kestrel.

The easiest place to test is QA, but if you want to test locally, run the Docker image:

dotnet build
cd src/Docker
docker compose build
docker compose up

Accessing Scripture Forge, and viewing network requests for static files will confirm that Brotli compressed versions are returned.


Open with Devin

This change is Reviewable

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 1.56250% with 63 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.32%. Comparing base (5132e3a) to head (0590fe2).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/SIL.XForge.Scripture/Startup.cs 1.56% 63 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3722      +/-   ##
==========================================
- Coverage   81.45%   81.32%   -0.13%     
==========================================
  Files         620      620              
  Lines       38960    39023      +63     
  Branches     6336     6341       +5     
==========================================
+ Hits        31734    31735       +1     
- Misses       6256     6318      +62     
  Partials      970      970              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmachapman pmachapman force-pushed the fix/SF-3513 branch 2 times, most recently from 99a1930 to 12c7e14 Compare March 3, 2026 01:49
devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

Copy link
Collaborator Author

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmachapman resolved 1 discussion and dismissed @github-advanced-security[bot] from a discussion.
Reviewable status: 0 of 3 files reviewed, all discussions resolved.

Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working from my testing. The static files are compressed to the br format.

@RaymondLuong3 reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@RaymondLuong3 RaymondLuong3 merged commit bdd850d into master Mar 3, 2026
22 checks passed
@RaymondLuong3 RaymondLuong3 deleted the fix/SF-3513 branch March 3, 2026 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants