SF-3704 Do not include deleted books in project progress#3716
SF-3704 Do not include deleted books in project progress#3716
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3716 +/- ##
==========================================
- Coverage 81.32% 81.30% -0.02%
==========================================
Files 620 620
Lines 39026 39032 +6
Branches 6341 6341
==========================================
Hits 31736 31736
- Misses 6320 6326 +6
Partials 970 970 ☔ View full report in Codecov by Sentry. |
Nateowami
left a comment
There was a problem hiding this comment.
@Nateowami reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).
src/SIL.XForge.Scripture/Services/SFProjectService.cs line 1886 at r1 (raw file):
BsonDocument verseSegmentOpsFilterExpression = new BsonDocument { { "input", new BsonDocument("$ifNull", new BsonArray { "$ops", new BsonArray() }) },
These changes look good, but I think we can remove both instances of $ifNull now that we're filtering out documents with no ops earlier in the process.
pmachapman
left a comment
There was a problem hiding this comment.
@pmachapman made 1 comment and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pmachapman).
src/SIL.XForge.Scripture/Services/SFProjectService.cs line 1886 at r1 (raw file):
Previously, Nateowami wrote…
These changes look good, but I think we can remove both instances of
$ifNullnow that we're filtering out documents with no ops earlier in the process.
Done. Good idea.
Nateowami
left a comment
There was a problem hiding this comment.
@Nateowami reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pmachapman).
This PR excludes text documents that do not have an ops array from the project progress query.
This change is