Skip to content

SF-3704 Do not include deleted books in project progress#3716

Merged
Nateowami merged 2 commits intomasterfrom
fix/SF-3704
Mar 5, 2026
Merged

SF-3704 Do not include deleted books in project progress#3716
Nateowami merged 2 commits intomasterfrom
fix/SF-3704

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Mar 2, 2026

This PR excludes text documents that do not have an ops array from the project progress query.


Open with Devin

This change is Reviewable

@pmachapman pmachapman added the will require testing PR should not be merged until testers confirm testing is complete label Mar 2, 2026
Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.30%. Comparing base (4bcfdeb) to head (3297fcb).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../SIL.XForge.Scripture/Services/SFProjectService.cs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3716      +/-   ##
==========================================
- Coverage   81.32%   81.30%   -0.02%     
==========================================
  Files         620      620              
  Lines       39026    39032       +6     
  Branches     6341     6341              
==========================================
  Hits        31736    31736              
- Misses       6320     6326       +6     
  Partials      970      970              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Nateowami Nateowami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nateowami reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).


src/SIL.XForge.Scripture/Services/SFProjectService.cs line 1886 at r1 (raw file):

        BsonDocument verseSegmentOpsFilterExpression = new BsonDocument
        {
            { "input", new BsonDocument("$ifNull", new BsonArray { "$ops", new BsonArray() }) },

These changes look good, but I think we can remove both instances of $ifNull now that we're filtering out documents with no ops earlier in the process.

@Nateowami Nateowami self-assigned this Mar 2, 2026
Copy link
Collaborator Author

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmachapman made 1 comment and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).


src/SIL.XForge.Scripture/Services/SFProjectService.cs line 1886 at r1 (raw file):

Previously, Nateowami wrote…

These changes look good, but I think we can remove both instances of $ifNull now that we're filtering out documents with no ops earlier in the process.

Done. Good idea.

Copy link
Collaborator

@Nateowami Nateowami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Nateowami reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@pmachapman pmachapman added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Mar 2, 2026
@Nateowami Nateowami added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Mar 5, 2026
@Nateowami Nateowami enabled auto-merge (squash) March 5, 2026 15:43
@Nateowami Nateowami merged commit 21b7a96 into master Mar 5, 2026
21 of 22 checks passed
@Nateowami Nateowami deleted the fix/SF-3704 branch March 5, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants