SF-3731 Show message on summary step when no training books selected

[RaymondLuong3]

A change in PR #3700 mistakenly ignored the case when there are no training books selected and did not show the "no training books" message on the draft summary step. Very few drafts use no training books, but it is possible. This corrects the logic so the message is shown on the summary step.

---

---

This change is 

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.75%. Comparing base (2cb0b81) to head (386c4b0).
⚠️ Report is 8 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3711   +/-   ##
=======================================
  Coverage   81.75%   81.75%           
=======================================
  Files         619      619           
  Lines       38634    38635    +1     
  Branches     6287     6307   +20     
=======================================
+ Hits        31585    31586    +1     
+ Misses       6090     6077   -13     
- Partials      959      972   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Nateowami]

@Nateowami made 2 comments.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on RaymondLuong3).

---

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.ts line 485 at r1 (raw file):

        .filter(b => b.selected)
        .map(b => b.number);
      if (trainingBooksBySource.length === 0) continue;

I think it would make more sense to just put the trainingRanges.push in an if

---

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.spec.ts line 1419 at r1 (raw file):

      component.onSourceTrainingBookSelect([], config.trainingSources[0]);
      component.onSourceTrainingBookSelect([], config.trainingSources[1]);
      expect(component.selectedTrainingBooksCollapsed().length).toEqual(0);

Shouldn't the assertion be that the text "No training books selected" is shown? I can't read this test and conclude that it tests what it intends to test.

[RaymondLuong3]

@RaymondLuong3 made 1 comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on Nateowami).

---

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.spec.ts line 1419 at r1 (raw file):

Previously, Nateowami wrote…

Shouldn't the assertion be that the text "No training books selected" is shown? I can't read this test and conclude that it tests what it intends to test.

Done.

[Nateowami]

@Nateowami reviewed 3 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on RaymondLuong3).