Make logic in resume-translate-service more robust#3699
Open
Make logic in resume-translate-service more robust#3699
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3699 +/- ##
=======================================
Coverage 81.83% 81.83%
=======================================
Files 619 619
Lines 38622 38628 +6
Branches 6317 6316 -1
=======================================
+ Hits 31605 31611 +6
- Misses 6043 6055 +12
+ Partials 974 962 -12 ☔ View full report in Codecov by Sentry. |
Nateowami
force-pushed
the
fix/resume-translate-logic
branch
2 times, most recently
from
9176be7 to
bc3c9ae
Compare
Nateowami
force-pushed
the
fix/resume-translate-logic
branch
from
bc3c9ae to
722dbd3
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The resume checking service recently had some bugs fixed related to incorrectly assuming the first book in a project's list of books is the first book canonically. The resume translate service had the same bug; it was just never reported as a Jira issue. This PR fixes it.
It also makes a similar fix in
project.component.tsThis change is