Skip to content

Move fw-lite log out of folders watched by Platform.Bible#2196

Merged
imnasnainaec merged 3 commits intodevelopfrom
bugfix/pb-ext-move-fw-lite-log
Mar 9, 2026
Merged

Move fw-lite log out of folders watched by Platform.Bible#2196
imnasnainaec merged 3 commits intodevelopfrom
bugfix/pb-ext-move-fw-lite-log

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Mar 6, 2026

Writing to the default fw-lite/fw-lite-web.log log file causes Platform.Bible to get stuck in a refresh loop because the containing directories are being watched. This pr sets LogFileName to ../../../fw-lite-extension.log. With this pr:

  • running npm start from languageforge-lexbox/platform.bible-extension/
    • generates languageforge-lexbox/fw-lite-extension.log generates no log file
    • instead of languageforge-lexbox/platform.bible-extension/dist/fw-lite/fw-lite-web.log;
  • running npm start from paranext-core/ (with a production build of fw-lite-extension copied in)
    • generates paranext-core/dev-appdata/fw-lite-extension.log generates no log file
    • instead of paranext-core/dev-appdata/installed-extensions/fw-lite-extension/fw-lite/fw-lite-web.log~

🌱 If it were possible to simply disable the log, that might be preferable. (I tried setting it to an empty string, but it just uses the default.) ...Tim did so.

@imnasnainaec imnasnainaec self-assigned this Mar 6, 2026
@imnasnainaec imnasnainaec added the 🟥High High-priority PR: please review this asap! label Mar 6, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 6, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 570c0880-4a37-42c9-8e10-a3164c215a7d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Adds a command-line argument to the fw-lite web launcher specifying a log file path (--FwLiteWeb:LogFileName=../../../fw-lite-extension.log) to ensure logs are written outside monitored directories.

Changes

Cohort / File(s) Summary
FW-Lite Web Launcher Configuration
platform.bible-extension/src/main.ts
Added log file argument to fw-lite spawn command to route logs to an external file location outside watched folders.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

📙 Platform.Bible, 🟨Medium

Suggested reviewers

  • myieye
  • jasonleenaylor

Poem

🐰 A log file path, so neat and true,
Outside the watched folders, fresh and new,
FW-Lite logs now have their home,
Safe from watchers' roaming tome! 📝

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: moving the fw-lite log file outside watched directories to prevent Platform.Bible refresh loops.
Description check ✅ Passed The description is directly related to the changeset, explaining the problem, the solution, and providing concrete examples of behavioral effects.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix/pb-ext-move-fw-lite-log

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related label Mar 9, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

UI unit Tests

  1 files  ±0   50 suites  ±0   27s ⏱️ +2s
138 tests ±0  138 ✅ ±0  0 💤 ±0  0 ❌ ±0 
203 runs  ±0  203 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 616c4ba. ± Comparison against base commit 6a341ca.

@argos-ci
Copy link

argos-ci bot commented Mar 9, 2026

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Mar 9, 2026, 1:37 PM

@myieye
Copy link
Collaborator

myieye commented Mar 9, 2026

I tested the flag in the context of just running FwLiteWeb and it seemed to be working.
So, I expect this is doing its job.

@imnasnainaec imnasnainaec merged commit 39a7877 into develop Mar 9, 2026
18 checks passed
@imnasnainaec imnasnainaec deleted the bugfix/pb-ext-move-fw-lite-log branch March 9, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related 🟥High High-priority PR: please review this asap! 📙 Platform.Bible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants