Move fw-lite log out of folders watched by Platform.Bible#2196
Move fw-lite log out of folders watched by Platform.Bible#2196imnasnainaec merged 3 commits intodevelopfrom
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughAdds a command-line argument to the fw-lite web launcher specifying a log file path ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
|
I tested the flag in the context of just running FwLiteWeb and it seemed to be working. |
Writing to the defaultWith this pr:fw-lite/fw-lite-web.loglog file causes Platform.Bible to get stuck in a refresh loop because the containing directories are being watched. This pr setsLogFileNameto../../../fw-lite-extension.log.npm startfromlanguageforge-lexbox/platform.bible-extension/generatesgenerates no log filelanguageforge-lexbox/fw-lite-extension.loglanguageforge-lexbox/platform.bible-extension/dist/fw-lite/fw-lite-web.log;npm startfromparanext-core/(with a production build of fw-lite-extension copied in)generatesgenerates no log fileparanext-core/dev-appdata/fw-lite-extension.logparanext-core/dev-appdata/installed-extensions/fw-lite-extension/fw-lite/fw-lite-web.log~🌱 If it were possible to simply disable the log,
that might be preferable. (I tried setting it to an empty string, but it just uses the default.)...Tim did so.