Skip to content

Improve full bleed support#3

Open
hatton wants to merge 10 commits intomasterfrom
improve-full-bleed-support
Open

Improve full bleed support#3
hatton wants to merge 10 commits intomasterfrom
improve-full-bleed-support

Conversation

@hatton
Copy link
Member

@hatton hatton commented Mar 2, 2026

Implements full-bleed behavior so source page box intent is preserved through passthrough and imposition flows.

Key changes:

  • Keep crop marks as an outer-margin concern (MediaBox growth) without changing intended trim/bleed geometry.

  • Update NullLayoutMethod to preserve source TrimBox/BleedBox and only offset boxes when crop marks are enabled.

  • Update SideFoldBookletLayouter to map source TrimBox to panel trim and clip drawing to mapped bleed bounds.

  • Fix right-edge crop-mark coordinate placement bug in DrawCropMarks.

  • Expand README Full Bleed documentation and clarify client responsibility for fold-edge behavior.


Open with Devin

This change is Reviewable

Implements full-bleed behavior so source page box intent is preserved through passthrough and imposition flows.

Key changes:

- Keep crop marks as an outer-margin concern (MediaBox growth) without changing intended trim/bleed geometry.

- Update NullLayoutMethod to preserve source TrimBox/BleedBox and only offset boxes when crop marks are enabled.

- Update SideFoldBookletLayouter to map source TrimBox to panel trim and clip drawing to mapped bleed bounds.

- Fix right-edge crop-mark coordinate placement bug in DrawCropMarks.

- Expand README Full Bleed documentation and clarify client responsibility for fold-edge behavior.
Copilot AI review requested due to automatic review settings March 2, 2026 22:50

This comment was marked as resolved.

Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 8 additional findings.

Open in Devin Review

It's not clear how/when this was useful to someone.
devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@hatton hatton force-pushed the improve-full-bleed-support branch from a608d5e to a41f238 Compare March 3, 2026 23:29
devin-ai-integration[bot]

This comment was marked as resolved.

@hatton
Copy link
Member Author

hatton commented Mar 4, 2026

[GPT-5.3-Codex] Addressed both unresolved RTL review findings.

  1. src/LayoutMethods/SideFold4UpBookletLayouter.cs (thread: Improve full bleed support #3 (comment))
    Fixed in commit 6d81303 by restoring _rightToLeft-aware box selection in DrawInferiorSide and DrawSuperiorSide, so superior/inferior page placement swaps correctly for RTL.

  2. src/LayoutMethods/SideFold4UpSingleBookletLayouter.cs (thread: Improve full bleed support #3 (comment))
    Fixed in commit 6d81303 by restoring _rightToLeft-aware box selection in all four corner draw methods.

Validation run:
dotnet test tests/sillsdev.dotImpose.csproj -c Debug -> 41 passed, 0 failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants